This repository has been archived by the owner. It is now read-only.

Add xfce4, including configuration that is suitable for touchscreen. #695

Merged
merged 2 commits into from Oct 7, 2017

Conversation

Projects
None yet
4 participants
@pavelmachek
Member

pavelmachek commented Oct 4, 2017

Nokia N900 does not have working hardware acceleration, so xfce4 with enlarged buttons is easiest way to usable user interface at the moment.

@ollieparanoid

Thank you for making this PR! I've added a few comments for what I'd like to discuss before merging.

@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Oct 5, 2017

Member

Ok, all but one comment. I'd like to keep separate repository for the files. It allows me to keep APKBUILD simple, may allow other projects to use it easily, and provides a place to put code such as top panel.

Member

pavelmachek commented Oct 5, 2017

Ok, all but one comment. I'd like to keep separate repository for the files. It allows me to keep APKBUILD simple, may allow other projects to use it easily, and provides a place to put code such as top panel.

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Oct 5, 2017

Member

Thanks for making the changes!

may allow other projects to use it easily

That is a good point. The package is called postmarketos-ui-xfce4 though, so I recommend that we put the xfce4-phone repository to the postmarketOS team on GitHub, would that make sense?

As always, we would set it up so you have all necessary rights (e.g. to write to the master branch).

provides a place to put code such as top panel.

It might make sense to put that in an extra package if this becomes something bigger, and possibly upstreaming it to xfce.

Member

ollieparanoid commented Oct 5, 2017

Thanks for making the changes!

may allow other projects to use it easily

That is a good point. The package is called postmarketos-ui-xfce4 though, so I recommend that we put the xfce4-phone repository to the postmarketOS team on GitHub, would that make sense?

As always, we would set it up so you have all necessary rights (e.g. to write to the master branch).

provides a place to put code such as top panel.

It might make sense to put that in an extra package if this becomes something bigger, and possibly upstreaming it to xfce.

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Oct 5, 2017

Member

As discussed in the chat, the repo is now here (you should have write access once you click the invite links, I think you get them per mail):
https://github.com/postmarketOS/xfce4-phone

It would be nice if you could review and test #696, so we can get both merged ASAP.

Member

ollieparanoid commented Oct 5, 2017

As discussed in the chat, the repo is now here (you should have write access once you click the invite links, I think you get them per mail):
https://github.com/postmarketOS/xfce4-phone

It would be nice if you could review and test #696, so we can get both merged ASAP.

@drebrez

This comment has been minimized.

Show comment
Hide comment
@drebrez

drebrez Oct 5, 2017

Member
/usr/bin/startxfce4: Starting X server
/etc/X11/xinit/xserverrc: exec: line 2: /usr/bin/X: not found

EDIT: my fault, there was also Xwayland installed, now it fails because of missing modules.
EDIT2: Installing the packages xf86-input-evdev, xf86-video-fbdev solves and start working.

2017-10-06 01 38 04

Member

drebrez commented Oct 5, 2017

/usr/bin/startxfce4: Starting X server
/etc/X11/xinit/xserverrc: exec: line 2: /usr/bin/X: not found

EDIT: my fault, there was also Xwayland installed, now it fails because of missing modules.
EDIT2: Installing the packages xf86-input-evdev, xf86-video-fbdev solves and start working.

2017-10-06 01 38 04

@drebrez

This comment has been minimized.

Show comment
Hide comment
@drebrez

drebrez Oct 6, 2017

Member

@pavelmachek I suggest adding the xfce4-battery-plugin package as a dependency, it recognize successfully the battery automatically and shows the percentage 👍

Member

drebrez commented Oct 6, 2017

@pavelmachek I suggest adding the xfce4-battery-plugin package as a dependency, it recognize successfully the battery automatically and shows the percentage 👍

@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Oct 6, 2017

Member
Member

pavelmachek commented Oct 6, 2017

@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Oct 6, 2017

Member

It seems to work on top of x11-install-if branch; moved repository as discussed on chat.

Member

pavelmachek commented Oct 6, 2017

It seems to work on top of x11-install-if branch; moved repository as discussed on chat.

@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Oct 6, 2017

Member
Member

pavelmachek commented Oct 6, 2017

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Oct 6, 2017

Member

@drebrez: Awesome photo!

@pavelmachek: At least on Android phones, it is usually very hard to see the console, but reading the log can really be useful, as it contains messages that are not in X11's log (example).

I have redirected the logging to ~/x11.log in postmarketos-ui-hildon now, how about we do the same here? It would be consistent then, and this should only be a workaround until we can properly redirect the logging to /var/log with a display manager anyway.

Other than that and rebasing this PR, I'd say let's ship it! 🚢

Member

ollieparanoid commented Oct 6, 2017

@drebrez: Awesome photo!

@pavelmachek: At least on Android phones, it is usually very hard to see the console, but reading the log can really be useful, as it contains messages that are not in X11's log (example).

I have redirected the logging to ~/x11.log in postmarketos-ui-hildon now, how about we do the same here? It would be consistent then, and this should only be a workaround until we can properly redirect the logging to /var/log with a display manager anyway.

Other than that and rebasing this PR, I'd say let's ship it! 🚢

Add xfce4.
This should address review comments, logging now goes to a file.
@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Oct 6, 2017

Member

Okay, here you go. This should address review comments, logging now goes to a file.

Member

pavelmachek commented Oct 6, 2017

Okay, here you go. This should address review comments, logging now goes to a file.

@ollieparanoid ollieparanoid merged commit ff1b96a into postmarketOS:master Oct 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Oct 7, 2017

Member

Merged. Thank you very much!

Member

ollieparanoid commented Oct 7, 2017

Merged. Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.