New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the 'internal' source #235

Merged
merged 2 commits into from Mar 30, 2017

Conversation

Projects
None yet
3 participants
@blt
Collaborator

blt commented Mar 29, 2017

This new source allows cernan to self-telemeter. It is not possible
for modules to report telemetry 'up' to be distributed through
the filter topology as operators see fit. This interface is
intentionally minimal and can be extended as need arises.

Closes #212

Signed-off-by: Brian L. Troutwine blt@postmates.com

Brian L. Troutwine
Introduce the 'internal' source
This new source allows cernan to self-telemeter. It is not possible
for modules to report telemetry 'up' to be distributed through
the filter topology as operators see fit. This interface is
intentionally minimal and can be extended as need arises.

Closes #212

Signed-off-by: Brian L. Troutwine <blt@postmates.com>

@blt blt requested review from tsantero and pulltab Mar 29, 2017

Show outdated Hide outdated src/source/statsd.rs
Show outdated Hide outdated src/source/internal.rs
@tsantero

+1, lgtm. fix up @pulltab's comments and merge!

Brian L. Troutwine
Address formatting feedback
This commit is a combination of addressing outstanding cargo fmt
flubs and whitespace policing by John.

Signed-off-by: Brian L. Troutwine <blt@postmates.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Mar 30, 2017

Codecov Report

Merging #235 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #235      +/-   ##
=========================================
+ Coverage   97.28%   97.5%   +0.22%     
=========================================
  Files          22      23       +1     
  Lines        3202    3248      +46     
=========================================
+ Hits         3115    3167      +52     
+ Misses         87      81       -6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1fbd2...8514000. Read the comment docs.

codecov bot commented Mar 30, 2017

Codecov Report

Merging #235 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #235      +/-   ##
=========================================
+ Coverage   97.28%   97.5%   +0.22%     
=========================================
  Files          22      23       +1     
  Lines        3202    3248      +46     
=========================================
+ Hits         3115    3167      +52     
+ Misses         87      81       -6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1fbd2...8514000. Read the comment docs.

@blt blt merged commit f26a094 into master Mar 30, 2017

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 97.5% (target 95%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@blt blt deleted the internal_source branch Mar 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment