New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the minimum CKMS error bound at 0.000_000_000_1 #10

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
1 participant
@blt
Collaborator

blt commented Jan 6, 2017

This commit fixes the minimum error bound at one in one-billion to
avoid a truncation to zero issue when we convert the insert_threshold
from a float to usize. This is kind of a lame fix--it'd be better to
take into account the value of std::usize::MAX--or avoid the float ->
usize conversion step entirely.

Signed-off-by: Brian L. Troutwine blt@postmates.com

Brian L. Troutwine
Fix the minimum CKMS error bound at 0.000_000_000_1
This commit fixes the minimum error bound at one in one-billion to
avoid a truncation to zero issue when we convert the insert_threshold
from a float to usize. This is kind of a lame fix--it'd be better to
take into account the value of std::usize::MAX--or avoid the float ->
usize conversion step entirely.

Signed-off-by: Brian L. Troutwine <blt@postmates.com>

@blt blt merged commit 0e3933d into master Jan 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@blt blt deleted the correct_threshold_error branch Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment