Permalink flush isn't always happening

[Shelob9]

Issue #39 indicates that the necessary permalink flush is not always happening... I presume, since we havn't heard more that this is an edge case, but still.

[soderlind]

Try this, replace

epoch/classes/core.php

Line 96 in 71ea40a

flush_rewrite_rules();

with

global $wp_rewrite;
$wp_rewrite->flush_rules();

[Shelob9]

@soderlind Yes, that is often the best way to do it. -1 me.

I know that epoch-api, pre-this version worked properly with ugly permalinks. Which might mean that the flush never worked, but wasn't needed. Got to check if the new rewrite rule for the iFrame is in fact ugly permalinks compatible, and our flush enables that.

[soderlind]

In my example plugin, I only flush if the permalink doesn't exist:

/**************************************************************************
 * Flushes the permalink structure.
 * flush_rules is an extremely costly function in terms of performance, and
 * should only be run when changing the rule.
 *
 * @see http://codex.wordpress.org/Rewrite_API/flush_rules
 **************************************************************************/
function my_permalink_flush_rewrite_rules() {
    $rules = $GLOBALS['wp_rewrite']->wp_rewrite_rules();
    if ( ! isset( $rules['my-permalink/(.*)$'] ) ) { // must be the same rule as in my_permalink_rewrite_rule($wp_rewrite)
        global $wp_rewrite;
        $wp_rewrite->flush_rules();
    }
}

[Shelob9]

close via a24c41f