Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Made the support files (gemspec, Gemfile, etc) look like goliath's) #1

Merged
merged 3 commits into from Jul 6, 2012

Conversation

Projects
None yet
2 participants
Member

mrflip commented Jun 23, 2012

Going to add some stuff, so first putting the house in order.

@igrigorik igrigorik commented on the diff Jul 5, 2012

goliath-contrib.gemspec
- gem.add_dependency 'goliath'
+ s.add_development_dependency 'rspec', '>2.0'
@igrigorik

igrigorik Jul 5, 2012

Owner

I don't think we need to replicate all the gems here? As long as we require goliath gem itself, we should inherit all the right deps.. no?

Otherwise we'll just fall out of sync.

@mrflip

mrflip Jul 6, 2012

Member

The ones I replicated were the development_dependencys, for Bundler's benefit. I don't have a good understanding the interplay among an app's Gemfile, its gemspec's development_dependency and dependencys, and the development_dependency/dependencys of the gems it in turn specifies, but my cargo-cult ritual is to put them in either the Gemfile or the gemspec as development dependencies.

I can confirm though that commenting eg tilt out of the gemspec (but leaving the goliath dependency) means that bundler doesn't include it:

# after commenting out that line in the gemspec
worblehat ~/ics/ext/goliath-contrib$ bundle exec ruby -e 'require "tilt"'
-e:1:in `require': cannot load such file -- tilt (LoadError)
    from -e:1:in `<main>'

Anyway: I think things like em-http-request aren't brought over by the simple dependency on goliath, so they need to either be here or in the gemfile. I put it here because I figured it could thus be easily diff'ed (which is also why I brought over the full list, not just the ones the examples referenced).

@igrigorik

igrigorik Jul 6, 2012

Owner

If we're moving middleware pieces out of core into contrib than then deps (including test libs) should be referenced here (in one place max).

I don't think we need nokogiri, etc, here.. unless we're explicitly using these libs in the contrib middleware.

Philip (flip) Kromer added some commits Jul 6, 2012

Rakefile does yard & tests too. Dependency list more minimalist.
The rakefile is copied from goliath; it now has tasks for running tests, making yardoc, etc
Member

mrflip commented Jul 6, 2012

Last commit knocks the list back to only what's needed now by code or for spec/yard/gem generation. The maruku/bluecloth are needed by YARD. EM::HTTP and postrank-uri are used by son_of_a_batch.

igrigorik added a commit that referenced this pull request Jul 6, 2012

Merge pull request #1 from mrflip/master
Made the support files (gemspec, Gemfile, etc) look like goliath's)

@igrigorik igrigorik merged commit 72d8c75 into postrank-labs:master Jul 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment