Skip to content

Nuke router #179

Merged
merged 6 commits into from May 11, 2012

5 participants

@dj2
postrank-labs member
dj2 commented May 7, 2012

Removing the routing logic from Goliath. This reverts back to before we added the original hacks for map support.

@igrigorik
postrank-labs member

I believe we can also remove the superclass middleware checks + logic, ex: https://github.com/postrank-labs/goliath/blob/master/lib/goliath/api.rb#L39-46

@dj2
postrank-labs member
dj2 commented May 8, 2012

done

@igrigorik igrigorik merged commit 7e841ba into master May 11, 2012
@radsaq
radsaq commented May 21, 2012

Pardon me if I haven't been paying close enough attention, but why all the hate for routes? This is pretty core to our usage...

@dj2
postrank-labs member
dj2 commented May 21, 2012

The router caused the majority of new bugs in Goliath. There were a lot of edge cases and other issues that came along with including routes.

What is it about routes that can't be handled by routing upstream at HAProxy or Nginx?

@abuiles
abuiles commented May 21, 2012

@radsaq you can get more context on the issue from this thread https://groups.google.com/group/goliath-io/browse_thread/thread/499c65efc04d8543.

@igrigorik
postrank-labs member

@radsaq there is no hate for routes. In fact, I hope we can bring back router functionality in a later release - perhaps with a slightly different API. The decision to remove it today is based solely on the fact that the API as it stands has led us into a couple of corner cases which I simply don't see how to resolve. So, you can blame it on me for not thinking through the implications upfront. :(

@radsaq
radsaq commented May 22, 2012

@igrigorik sorry, I meant "hate" in the loosest sense. ;) I think for our usage (size of project, traffic, etc.), at least for the time being, it's just easier to keep everything in one server. But we'll just wait for a post-1.0 release or do it manually. Thanks!

@deeperx
deeperx commented on 6fffbc7 Sep 1, 2012

Why did you remove this? How can I add routes now?

https://groups.google.com/forum/m/?fromgroups#!topic/goliath-io/qhzbRyp6fCA

For anyone looking for a simpler solution: Grape + Goliath

But, he's (David) not sure about the performance/principles of this marriage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.