Application should be a module #207

Merged
merged 1 commit into from Sep 28, 2012

Conversation

Projects
None yet
3 participants
Contributor

tomykaira commented Sep 26, 2012

It has only class methods. Therefore there is no reason to be a class.

Application.camel_case is expected to be private, but it was not.

Application should be a module
It has only class methods.

Application.camel_case is expected to be private, but it was not.
Owner

igrigorik commented Sep 26, 2012

Looks good to me.

/cc @dj2 - sanity check :-)

Owner

dj2 commented Sep 26, 2012

What's the benefit of making it a module? It still feels like class to me.

Contributor

tomykaira commented Sep 27, 2012

Application class has no instances, nor subclasses, as far as I searched.

A module obviously has such characteristic, therefore it is easy to understand.

There will be other points of view about such singleton-like object in ruby.

Owner

dj2 commented Sep 27, 2012

As long as all the examples work correctly I don't see anything wrong with doing this.

igrigorik added a commit that referenced this pull request Sep 28, 2012

@igrigorik igrigorik merged commit eda8313 into postrank-labs:master Sep 28, 2012

1 check passed

default The Travis build passed
Details
Owner

igrigorik commented Sep 28, 2012

Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment