connectionCloseOK, queueUnbindOK, basicCancelOK missing #64

Open
dathan opened this Issue Jan 27, 2012 · 1 comment

2 participants

@dathan

Also added the ability to close a connection via

Connection.prototype.closeConnection = function () {
//
// 0 is the control channel
//
this._sendMethod(0, methods.connectionClose, {'replyText': 'Goodbye from node',
'replyCode': 200,
'classId': 0,
'methodId': 0});
//this.end();
};

then on _onMethod

case methods.connectionCloseOk:
this.end();
this._onMethod(0, methods.connectionClose, args);
break;

I end the connection. I don't know how to do the social commit or things that make github great. I can push these to you if you like.

@alfonsoabad

I'm having a 'connection_closed_abruptly' message in the rabbitmq log, I'm gonna try @dathan suggestion, to see if this solves the issue.

@dathan : About the "social commit" , I think you meant "pull request" you can learn more in https://help.github.com/articles/using-pull-requests is about how contributors send commits from their forks to the main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment