Pull request for old stuff #17

Open
wants to merge 24 commits into
from

Conversation

Projects
None yet
2 participants

Hi Padraig

To follow up on an old email discussion we had (subject "More API changes" from May 2010)

I had done these changes we discussed, but with the recent changes in the 0.7/master branch they were lost.

I pulled your master and re-implemented these changes, along with a new feature I've had in my branch for a while (Connect, read, write timeout support).

If you find them useful it'd be good if you can pull them into your branch, as it seems out of all the github forks yours is the most active/authoritative/up to date.

Unrelated 1:
Regarding my (very old) "libcassie" branch (C library for cassandra), I'm actually using it in production in my company, and have very recently started a child branch to bring it up to speed with your 0.7 changes.

Once your 0.7 branch/master stabilizes I'll aim for 100% API coverage of libcassandra in libcassie, then I'll offer it up for public consumption (perhaps even bubble up to master in my repo / yours).

Unrelated 2:
Any C++ books you recommend for a C programmer ? I still find C++ syntax, references, shared pointers and other language constructs fairly challenging.

Thank you, and keep up the great work :)

Mina Naguib and others added some commits Jun 17, 2010

Mina Naguib * Replace getSliceNames and getSliceRange with getColumns and getSup…
…erColumns

 * Better examples
9465ae8
Mina Naguib Version bump due to API change 7235706
Mina Naguib * Bugfix Keyspace::remove not handling super_column properly
 * Add Keyspace::removeColumn variant with no super_column_name in signature
 * Extend examples/simple.cc with more and better examples
a009b32
@eyealike eyealike Eliminate hard-coded include path in M4 macro for Thrift 1d60823
@eyealike eyealike Trail upstream relocation of thrift headers 48ce0c1
@eyealike eyealike Add .svn to .gitignore a615874
@eyealike eyealike Added Debian packaging b8a7d5e
@eyealike eyealike Added top.h to .gitignore 4139686
@eyealike eyealike Use quotes for intra-project includes
(in case libcassandra is in /usr on the build machine)
98cc2d6
@eyealike eyealike Fix: Keyspace::remove() didn't work against super-column families.
Add updated libtool-relared m4's.
8b10035
@eyealike eyealike Fixed dependencies in Debian packaging. Added libgenthrift/configure.…
…h to .gitignore.
3b21bdf
Mina Naguib Merge remote branch 'eyealike/master' 3268ee1
Mina Naguib Revert "Trail upstream relocation of thrift headers"
This reverts commit 48ce0c1.
47dc533
Mina Naguib Fix broken detection of libthrift 6f4a213
Mina Naguib Compiling now works again (Add THRIFT_PREFIX/include/thrift to includ…
…e path)
c353de5
Mina Naguib Bump up to thrift 0.4, with generated interface version 2.2.0 (from c…
…assandra 0.6.4)
c5c4967
Mina Naguib Unfortunately thrift-s output needs a bit of tweaking before it will …
…compile
e5c7cf1
Mina Naguib Merge remote-tracking branch 'posulliv/master' - NOTE - due to
Padraig's refactoring (moving lots of methods from Keyspace to
Cassandra), a couple of my changes were lost.  To be re-done in next
commit

Conflicts:
	.gitignore
	examples/get_drizzle_data.cc
	examples/simple.cc
	libcassandra/cassandra.cc
	libcassandra/cassandra_factory.cc
	libcassandra/keyspace.cc
	libcassandra/keyspace.h
	libcassandra/keyspace_factory.cc
	libgenthrift/Cassandra.cpp
	libgenthrift/Cassandra.h
	libgenthrift/Cassandra_server.skeleton.cpp
	libgenthrift/cassandra_constants.cpp
	libgenthrift/cassandra_types.h
	m4/ltversion.m4
	m4/pandora_have_thrift.m4
f0628c3
Mina Naguib Re-implement commit 9465ae8 after merging in 0.7 refactorization: Rep…
…lace getSliceNames and getSliceRange with getColumns and getSuperColumns
7fb71ea
Mina Naguib Cherry-pick commits 71676d1 and 2e1291b from libcassie's branch: Impl…
…ement connect/send/receive timeout support
e678083
Mina Naguib Re-generate libgenthrift using thrift 0.6.0 3de7beb
Mina Naguib Usual fix after libgenthrift update to make compiling work again c970110
Mina Naguib Fix memleak if socket opening fails during construction as reported in cb68df9
@minaguib minaguib Update README dbc365e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment