Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format redux #108

Open
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@seanmiddleditch
Copy link
Collaborator

commented Jun 8, 2019

Add a CI job that checks formatting of source/header files applies our settings from .clang-format.

The output is... not great. I am having trouble getting particularly useful output. A sample failure can be found at https://seanmiddleditch.visualstudio.com/potato/_build/results?buildId=884

I think perhaps adding the diff back into that view might be useful, just also with the warnings to note the files that have errors (note it only shows the first error in a file). I can't get Azure to reliably post GitHub Annotations, much less any actually useful annotations.

That said, even without the diff, it's usually just enough to open each file and resave. In VS, a file can be fixed via ctrl-K ctrl-D.

Once Azure is updated to allow it, we can do some more work to auto-apply style fixes right in the PR CI feedback at the click of a button.

@seanmiddleditch seanmiddleditch force-pushed the clang-format-redux branch from d30b8a1 to ce03328 Jun 8, 2019

@seanmiddleditch seanmiddleditch force-pushed the clang-format-redux branch 11 times, most recently from de99130 to 19aaf45 Jun 8, 2019

@seanmiddleditch seanmiddleditch force-pushed the clang-format-redux branch from 19aaf45 to 47cac0b Jun 9, 2019

@seanmiddleditch seanmiddleditch force-pushed the clang-format-redux branch from 1314a75 to ad1a5e0 Jun 9, 2019

@seanmiddleditch seanmiddleditch force-pushed the clang-format-redux branch from ad1a5e0 to 9a9527b Jun 9, 2019

@seanmiddleditch seanmiddleditch force-pushed the clang-format-redux branch from 4842edd to 04dd029 Jun 9, 2019

seanmiddleditch added some commits Jun 9, 2019

Use clang-format-7
clang-format changes its output between versions, and now we have a mismatch
between what the CI system wants and what VS will apply itself.

@seanmiddleditch seanmiddleditch force-pushed the clang-format-redux branch from f96bc7c to caf7555 Jun 9, 2019

@seanmiddleditch seanmiddleditch requested a review from marcinwie Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.