New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Configuration - Event Names and Sorting #484

Open
ClockworkEJD opened this Issue Oct 13, 2017 · 10 comments

Comments

Projects
None yet
2 participants
@ClockworkEJD

ClockworkEJD commented Oct 13, 2017

Hello,

In the Event Configuration, each event has an Event Name but the Event Name is not visible in the list of events and there is no way to sort the events without manually hitting up-arrow or down-arrow for each one to manually sort the list. For worlds with large numbers of events this becomes very unwieldy.

I understand that the events are also executed in order. So perhaps a numeric sort column as well. Or a way to drag and drop the events in order rather than having to click the up/down arrow a hundred times each time.

Ideally it would be nice to see the list as:

Number - Event Name - Event

1 - OOC Filter - ^((OOC)) (regexp)
2 - Page Highlight - ^(From afar|Long distance to|\S.+? pages:|You paged .+? with|Player .+? pages you:).*$

Then having the ability to sort by Number or by Event Name, with the ability to drag items around to move them would be helpful.

I love Potato and all of its features and have been using it for some time. This is the one area in which I find the interface challenging.

Thanks!

@talvo

This comment has been minimized.

Collaborator

talvo commented Feb 19, 2018

OK, as a start I've added drag-and-drop to order. If there's any other place you'd like to see this, let me know.

I'll keep the ticket open and look into redoing the window so it shows the event name in the left as well.

@ClockworkEJD

This comment has been minimized.

ClockworkEJD commented Feb 20, 2018

I can't tell you how excited I am about this! Thanks so much for looking into it. I look forward to seeing it in action.

@ClockworkEJD

This comment has been minimized.

ClockworkEJD commented Feb 20, 2018

Noticed something strange. This world has a LOT of definitions. As I began to move them around, I noticed that they didn't always stay put. The ones at the top would periodically appear further down the list seemingly at random. Then I noticed this.

I clicked on the one for my pages, but the event name and definition that shows up on the right is the one for the one above it.

Then, I exited out of the Event Configuration window and it doesn't seem that the new positions were saved at all.

Something seems to be going awry.

@ClockworkEJD

This comment has been minimized.

ClockworkEJD commented Feb 20, 2018

Did a little more testing and if you sort using the arrows, then close the Event Configuration window, it does still save the positions.

So there's some difference between the drag and drop and the arrow positioning that is causing it not to save the changed position, it seems.

@talvo

This comment has been minimized.

Collaborator

talvo commented Feb 20, 2018

Oh, you want to be able to drag them and have it save them in that order? Well, look who wants the world... ;) Thanks for the heads-up, I'll check and see what I missed. Was overdue for bed when I did it, so I just checked the dragging was working and didn't actually test further.

@ClockworkEJD

This comment has been minimized.

ClockworkEJD commented Feb 21, 2018

toescuffs Yeaaaaah. Kindaaaa. I know, I know, I want ALL THE THINGS!

And bed is important. Yeay for sleep! And hey, this way you outsourced the testing! >.> We can call that a strategic move.

@talvo

This comment has been minimized.

Collaborator

talvo commented Feb 21, 2018

OK, now it hopefully saves them in the right order after you drag and drop, and everything else seems to be working too. Emphasis on seems. ;) Would be grateful if you could give it a test for me. (You may want to make a backup copy of your "worlds" directory first, just in case I borked something, so you don't have to go in and fix those many, many, many, many events manually if it breaks.)

@ClockworkEJD

This comment has been minimized.

ClockworkEJD commented Feb 23, 2018

Okay, so, here's what I found:

In a world with a short list of names, I could drag and drop and they saved where I put them.

In a world with a long list of names, if I moved items individually, they would stay put. So if I move one item up or down the list, then exit the list, it saves.

If I move two to three items a short distance up or down the list, they seem to save.

If I move items from the top of the list further down the list, things start jumping around again, showing the wrong labels, etc. If I move items from the bottom of the list way up the list, it does it as well. And it seems any movement of more than a couple of items causes the issue.

removed

I've included a copy of the World File which has some 300 events in it if you want to play around with it to see what happens in the big list. I blocked out the passwords but if you could remove it from here after you grab it, that'd be cool.

In small lists where the window didn't scroll, I didn't notice the issue. Once I used world files with around 50 or so events in them, I started noticing it.

So I just did another test, and if I took a world with a small number of items and I made the Event Configuration window small so it had to scroll even with under 50 items, it started doing it as well.

So it seems to have something to do with dragging something outside of the view of the list where it has to scroll before the dragging stops. And that seems to go along with my tests earlier, where moving things within the same "view" without scrolling didn't seem to exhibit any problems.

@talvo

This comment has been minimized.

Collaborator

talvo commented Feb 23, 2018

Thanks, I will take a look and see what I can replicate/fix.

@ClockworkEJD

This comment has been minimized.

ClockworkEJD commented Mar 3, 2018

Cool cool. Thanks for looking into it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment