Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
24 bit color support #495
Hi, I was messing around with your application and I wanted to give it 24 bit color support, but the way that that tk text tags are configured, this looks like it might be rather... weighty...
In fact, it seems to consistently crash on startup when configuring all of the tags.
I'm not very experienced with using tk, but... This doesn't feel like it's the right way to do it, and I don't know if what I'm doing is even possible without being absurd.
Hi. Yeah, you would be looking at adding one tag per colour, and with that many, you're definitely going to have performance issues (though I'm surprised you're seeing outright crashes). But even with the 256 colour support, having all the colours on screen at once in multiple ranges causes a significant performance hit, so it's unfortunately probably not viable/practical to go for 24bit.
If you did want to, I'd recommend only adding the tags as and when the colours actually get used, rather than defining them all together on startup (realistically, during any one connection, you'll probably only have a fraction of them actually in use).
Is there actually a MU codebase that supports 24bit colour? If so, what protocol is it using?
It's using the ansi spec listed on the wikipedia article, (well, it might be once I've got potato to handle it right).
Xserver killed the window actually, since it seems that each tag creates a resource for it to manage, and it doesn't want that many.
Although this complicates the way I'd done it, since I'm not experienced enough to know if I can even get the text pane component at the proper place for instantiating those tags, ideally the handleAnsiCode proc.