New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parentheses to remove the ambiguity on Elixir 1.4 #26

Merged
merged 1 commit into from Dec 11, 2016

Conversation

Projects
None yet
2 participants
@alexandrubagu
Copy link
Contributor

alexandrubagu commented Dec 9, 2016

When using Elixir 1.4 new warnings are raised:

warning: variable "erlc_options" does not exist and is being expanded to "erlc_options()", please use parentheses to remove the ambiguity or change the variable name
  /home/alexandrubagu/devel/antidote/deps/jose/mix.exs:8

warning: variable "deps" does not exist and is being expanded to "deps()", please use parentheses to remove the ambiguity or change the variable name
  /home/alexandrubagu/devel/antidote/deps/jose/mix.exs:11

warning: variable "description" does not exist and is being expanded to "description()", please use parentheses to remove the ambiguity or change the variable name
  /home/alexandrubagu/devel/antidote/deps/jose/mix.exs:19

warning: variable "package" does not exist and is being expanded to "package()", please use parentheses to remove the ambiguity or change the variable name
  /home/alexandrubagu/devel/antidote/deps/jose/mix.exs:20

@alexandrubagu alexandrubagu changed the title add parentheses to remove the ambiguity add parentheses to remove the ambiguity on Elixir 1.4 Dec 9, 2016

@potatosalad

This comment has been minimized.

Copy link
Owner

potatosalad commented Dec 11, 2016

@alexandrubagu Awesome, thanks!

@potatosalad potatosalad merged commit fcd8afd into potatosalad:master Dec 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandrubagu

This comment has been minimized.

Copy link
Contributor Author

alexandrubagu commented Feb 2, 2017

Can you create a new tag with this ? There are libraries which still use 1.8 tag and are warnings when you compile

potatosalad added a commit that referenced this pull request Feb 2, 2017

Version 1.8.1
* Fixes
  * Parentheses to remove ambiguity on Elixir 1.4 #26, thanks @alexandrubagu
@potatosalad

This comment has been minimized.

Copy link
Owner

potatosalad commented Feb 2, 2017

@alexandrubagu Just published version 1.8.1 with your changes included. Thanks!

@alexandrubagu

This comment has been minimized.

Copy link
Contributor Author

alexandrubagu commented Feb 3, 2017

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment