Skip to content

Conversation

@ramonfincken
Copy link

[BUGFIX] Nginx if directory should have "" instead of ()

if not changed nginx -t fails on
nginx: [emerg] invalid condition "$http_user_agent" in ..

@pothi pothi merged commit c8e8705 into pothi:master Mar 23, 2018
@pothi
Copy link
Owner

pothi commented Mar 23, 2018

Hello,

Thanks for the bug report and pull request. It could happen when a new "user agent" string is added to the list without escaping special characters (such as space) with a backslash. We can't expect the user to escape the "user agent" string in advance. So, changing braces to quotes (single or double) is more compatible and more user-friendly.

Thanks again,
Pothi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants