Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setBandwidth/getBandwidth no-ops, should call rtlsdr_set_and_get_tuner_bandwidth? #20

Open
rxseger opened this issue Jul 17, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@rxseger
Copy link

commented Jul 17, 2016

SoapyRTLSDR's bandwidth methods currently only call the stubs in the superclass, which return 0 Hz:

SoapyRTLSDR/Settings.cpp

Lines 448 to 463 in a44abc3

void SoapyRTLSDR::setBandwidth(const int direction, const size_t channel, const double bw)
{
SoapySDR::Device::setBandwidth(direction, channel, bw);
}
double SoapyRTLSDR::getBandwidth(const int direction, const size_t channel) const
{
return SoapySDR::Device::getBandwidth(direction, channel);
}
std::vector<double> SoapyRTLSDR::listBandwidths(const int direction, const size_t channel) const
{
std::vector<double> results;
return results;
}

https://github.com/pothosware/SoapySDR/blob/master/lib/Device.cpp#L486-L499

should these methods be bridged to librtlsdr's rtlsdr_set_and_get_tuner_bandwidth() (and/or rtlsdr_set_tuner_bandwidth()??

Note that these librtlsdr APIs to get/set bandwidth are relatively new, not all installations may necessarily have it yet, so it may be worth holding off until it can be confirmed it is widely available as needed. I have no immediate need for it, just noticed this gap in librtlsdr->SoapyRTLSDR bridging while working on something else.

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.