New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting PhotoLink and other settings #33

Closed
brettalton opened this Issue Apr 3, 2013 · 3 comments

Comments

2 participants
@brettalton

brettalton commented Apr 3, 2013

I think there should be the ability to build your own anchor if you'd like and be able to overwrite the settings. So instead of using

settings = {
  // ...
  , photoLink: true
};

You allow for the ability to override or not. Current it just says,

if (settings.photoLink) {
  innerHtml = $('<a>')
    .attr('target', '_blank')
    .attr('href', photo.link)
    .append(innerHtml);
}

which only allows for bool.

And now that I have this script on CDNjs (http://cdnjs.com), vanilla copies may be preferred, rather than custom hacks to source code.

@potomak

This comment has been minimized.

Owner

potomak commented Apr 3, 2013

I agree, but I'd like to let customize HTML code generation by overriding the onComplete callback, see #21.

@ghost

This comment has been minimized.

ghost commented Jul 23, 2013

is there currently anyway to override the HTML as proposed above? I would like to enlarge images using a lightbox versus bringing the user to the instagram site.

@potomak

This comment has been minimized.

Owner

potomak commented Aug 10, 2013

Since version 0.3.0 plugin doesn't generate code anymore, see also documentation for the didLoadInstagram event: https://github.com/potomak/jquery-instagram#didloadinstagram

@potomak potomak closed this Aug 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment