Skip to content
This repository has been archived by the owner. It is now read-only.

Overwriting PhotoLink and other settings #33

Closed
brettalton opened this issue Apr 3, 2013 · 3 comments
Closed

Overwriting PhotoLink and other settings #33

brettalton opened this issue Apr 3, 2013 · 3 comments

Comments

@brettalton
Copy link

@brettalton brettalton commented Apr 3, 2013

I think there should be the ability to build your own anchor if you'd like and be able to overwrite the settings. So instead of using

settings = {
  // ...
  , photoLink: true
};

You allow for the ability to override or not. Current it just says,

if (settings.photoLink) {
  innerHtml = $('<a>')
    .attr('target', '_blank')
    .attr('href', photo.link)
    .append(innerHtml);
}

which only allows for bool.

And now that I have this script on CDNjs (http://cdnjs.com), vanilla copies may be preferred, rather than custom hacks to source code.

@potomak
Copy link
Owner

@potomak potomak commented Apr 3, 2013

I agree, but I'd like to let customize HTML code generation by overriding the onComplete callback, see #21.

@ghost
Copy link

@ghost ghost commented Jul 23, 2013

is there currently anyway to override the HTML as proposed above? I would like to enlarge images using a lightbox versus bringing the user to the instagram site.

@potomak
Copy link
Owner

@potomak potomak commented Aug 10, 2013

Since version 0.3.0 plugin doesn't generate code anymore, see also documentation for the didLoadInstagram event: https://github.com/potomak/jquery-instagram#didloadinstagram

@potomak potomak closed this Aug 10, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants