New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#18) - Support AMD #20

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ddouglascarr
Copy link

ddouglascarr commented Apr 2, 2015

Adds support for require.js and the like.

For issue #18

ddouglascarr added some commits Apr 2, 2015

@ddouglascarr ddouglascarr changed the title Support AMD (#18) - Support AMD Apr 2, 2015

@nolanlawson

This comment has been minimized.

Copy link
Member

nolanlawson commented Apr 6, 2015

I've taken a stance with all my plugins to not support AMD or UMD, because it would be too much effort to fix all of my projects to support every JavaScript packaging format.

If you'd like to use AMD, then you are encouraged to build from source. dist is a convenience thing for old-school people who still prefer globals (which based on the research I've done, is the vast majority of JavaScript users). Sorry to be "that guy" about this, but gonna close this issue.

@nolanlawson nolanlawson closed this Apr 6, 2015

@nolanlawson nolanlawson referenced this pull request Apr 6, 2015

Closed

AMD Support #18

@nolanlawson

This comment has been minimized.

Copy link
Member

nolanlawson commented Apr 6, 2015

Actually on second thought, since this seems like such a clean PR, maybe I should look into applying this patch to all my plugins as well as the plugin-seed.

@ddouglascarr something I don't understand - have you been able to use PouchDB with RequireJS/AMD up to this point? I wasn't aware we were even supporting it in PouchDB itself.

@nolanlawson nolanlawson reopened this Apr 6, 2015

@ddouglascarr

This comment has been minimized.

Copy link

ddouglascarr commented Apr 7, 2015

Hi @nolanlawson.

PouchDB just worked for me with require.js. Most libraries that create a global attribute do. The reason that the plugin doesn't is because it tries to modify the PouchDB global, which is not the PouchDB that it has access to.

I fully understand your attitude towards AMD loaders, and would probably adapt a similar policy myself in your position.

@nolanlawson

This comment has been minimized.

Copy link
Member

nolanlawson commented Apr 25, 2015

Yeah, I think I just don't want to support AMD. Too much effort, and people can always write wrappers for browserify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment