-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async transforms #19
async transforms #19
Conversation
Hm, seems to be failing due to some change in Watchify/Browserify. I think this is a great feature, though, so I will try to fix and merge this soon. Thanks! :) |
yeah I was getting an install error when I tried to insteall the deps but wasn't sure which so I bumped most of them, I know watchify has a api change that has hit us in the past |
Yeah I think I need to just update all of them and clean up this repo. Will do and then I'll merge and push a new version. |
I can’t get the tests to pass locally when running
I’ve updated all dependencies to their latest version (excl jshint). |
I'm happy to help get this merged, any pointers? |
I think that fixes the issue: // bin/dev-server.js
-var w = watchify(indexfile);
+var browserify = require('browserify');
+var watchify = require('watchify');
+
+var w = browserify({
+ entries: [indexfile],
+ cache: {},
+ packageCache: {},
+ plugin: [watchify]
+}); |
We have bigger problems: the master branch is currently failing due to some breaking changes in some dependency somewhere. 😩 |
closing in favor of #24 |
totally backwards compatible but now you can return promises, the updates to the dev deps of the package.json are to get the tests to run.