Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async transforms #19

Closed
wants to merge 1 commit into from

Conversation

calvinmetcalf
Copy link
Collaborator

totally backwards compatible but now you can return promises, the updates to the dev deps of the package.json are to get the tests to run.

@nolanlawson
Copy link
Member

Hm, seems to be failing due to some change in Watchify/Browserify. I think this is a great feature, though, so I will try to fix and merge this soon. Thanks! :)

@calvinmetcalf
Copy link
Collaborator Author

yeah I was getting an install error when I tried to insteall the deps but wasn't sure which so I bumped most of them, I know watchify has a api change that has hit us in the past

@nolanlawson
Copy link
Member

Yeah I think I need to just update all of them and clean up this repo. Will do and then I'll merge and push a new version.

@gr2m
Copy link
Collaborator

gr2m commented Apr 5, 2016

I can’t get the tests to pass locally when running CLIENT=selenium:firefox npm test. I get

transform-pouch/node_modules/watchify/index.js:14
    var cache = b._options.cache;
                          ^

TypeError: Cannot read property 'cache' of undefined
    at watchify (/Users/gregor/Projects/transform-pouch/node_modules/watchify/index.js:14:27)
    at Object.<anonymous> (/Users/gregor/Projects/transform-pouch/bin/dev-server.js:17:9)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/gregor/Projects/transform-pouch/bin/test-browser.js:9:17)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Function.Module.runMain (module.js:467:10)
    at startup (node.js:136:18)
    at node.js:963:3

I’ve updated all dependencies to their latest version (excl jshint). npm test passes

@gr2m
Copy link
Collaborator

gr2m commented Apr 5, 2016

I'm happy to help get this merged, any pointers?

@gr2m
Copy link
Collaborator

gr2m commented Apr 5, 2016

I think that fixes the issue:

// bin/dev-server.js
-var w = watchify(indexfile);
+var browserify = require('browserify');
+var watchify = require('watchify');
+
+var w = browserify({
+  entries: [indexfile],
+  cache: {},
+  packageCache: {},
+  plugin: [watchify]
+});

@gr2m gr2m mentioned this pull request Apr 5, 2016
@nolanlawson
Copy link
Member

We have bigger problems: the master branch is currently failing due to some breaking changes in some dependency somewhere. 😩

@nolanlawson
Copy link
Member

closing in favor of #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants