tests/browser.migration: also run with indexeddb (#8766)

Author: alxndrsn

tests/integration/browser.migration.js

@@ -2,13 +2,23 @@
 
 describe('migration', function () {
 
-  function usingDefaultPreferredAdapters() {
+  function usingIdb() {
     var pref = PouchDB.preferredAdapters;
     // Firefox will have ['idb'], Chrome will have ['idb', 'websql']
     return (pref.length === 1 && pref[0] === 'idb') ||
       (pref.length === 2 && pref[0] === 'idb' && pref[1] === 'websql');
   }
 
+  function usingIndexeddb() {
+    const pref = PouchDB.preferredAdapters;
+    // FUTURE: treat indexeddb adapter as the preferred option?
+    return pref.length === 1 && pref[0] === 'indexeddb';
+  }
+
+  function usingDefaultPreferredAdapters() {
+    return usingIdb() || usingIndexeddb();
+  }
+
   const scenarios = [
     { scenario: 'PouchDB v1.1.0', constructorName: 'PouchDBVersion110'} ,
     { scenario: 'PouchDB v2.0.0', constructorName: 'PouchDBVersion200'} ,
@@ -43,7 +53,15 @@ describe('migration', function () {
       if (!match) {
         return testUtils.Promise.resolve();
       }
-      return testUtils.asyncLoadScript('deps/pouchdb-' + match[1] + '-postfixed.js');
+
+      const loader = testUtils.asyncLoadScript('deps/pouchdb-' + match[1] + '-postfixed.js');
+
+      if (usingIndexeddb() && versionGte(scenario, '7.2.1')) {
+        return loader
+            .then(() => testUtils.asyncLoadScript('deps/pouchdb-' + match[1] + '-indexeddb-postfixed.js'));
+      } else {
+        return loader;
+      }
     }));
   });
 
@@ -86,6 +104,12 @@ describe('migration', function () {
 
         if (scenario in PouchDB.adapters) {
           dbs.first.localOpts.adapter = scenario;
+        } else if (usingIndexeddb()) {
+          // use indexeddb adapter for both old and new DBs:
+          // * cannot currently migrate idb -> indexeddb automatically
+          // * in these tests, idb adapter is always the default for old PouchDB
+          //   bundles, even if indexeddb is available
+          dbs.first.localOpts.adapter = 'indexeddb';
         }
         // else scenario might not make sense for this browser, so just use
         // same adapter for both
@@ -98,6 +122,12 @@ describe('migration', function () {
         testUtils.cleanup([dbs.first.local, dbs.second.local], done);
       });
 
+      before(function () {
+        if (usingIndexeddb() && !versionGte(scenario, '7.2.1')) {
+          return this.skip();
+        }
+      });
+
       var origDocs = [
         {_id: '0', a: 1, b: 1},
         {_id: '3', a: 4, b: 16},
@@ -244,7 +274,7 @@ describe('migration', function () {
         });
       });
 
-      if (oldVersionGte('2.2.0')) {
+      if (versionGte(scenario, '2.2.0')) {
         it("Test persistent views don't require update", function (done) {
           var oldPouch = new dbs.first.pouch(dbs.first.local, dbs.first.localOpts);
           var docs = origDocs.slice().concat([{
@@ -420,7 +450,7 @@ describe('migration', function () {
         });
       }
 
-      if (oldVersionGte('3.0.6')) {
+      if (versionGte(scenario, '3.0.6')) {
         // attachments didn't really work until this release
         it('#2818 Testing attachments with compaction of dups', function () {
           var docs = [
@@ -819,7 +849,7 @@ describe('migration', function () {
         });
       }
 
-      if (oldVersionGte('3.2.0')) {
+      if (versionGte(scenario, '3.2.0')) {
         it('#3136 Testing later winningSeqs', function () {
           var tree = [
             [
@@ -898,7 +928,7 @@ describe('migration', function () {
         });
       }
 
-      if (oldVersionGte('3.6.0')) {
+      if (versionGte(scenario, '3.6.0')) {
         it('#3646 - Should finish with 0 documents', function () {
           var data = [
             {
@@ -1134,20 +1164,20 @@ describe('migration', function () {
         });
       }
     });
+  });
+});
 
-    function oldVersionGte(minimumRequired) {
-      const match = scenario.match(/^PouchDB v([.\d]+)$/);
-      if (!match) { return false; }
-      const actual = match[1].split('.');
+function versionGte(scenario, minimumRequired) {
+  const match = scenario.match(/^PouchDB v([.\d]+)$/);
+  if (!match) { return false; }
+  const actual = match[1].split('.');
 
-      const min = minimumRequired.split('.');
+  const min = minimumRequired.split('.');
 
-      for (let i=0; i<min.length; ++i) {
-        if (actual[i] > min[i]) { return true; }
-        if (actual[i] < min[i]) { return false; }
-      }
+  for (let i=0; i<min.length; ++i) {
+    if (actual[i] > min[i]) { return true; }
+    if (actual[i] < min[i]) { return false; }
+  }
 
-      return true;
-    }
-  });
-});
+  return true;
+}

tests/integration/deps/get-postfixed-pouchdb-build.sh

@@ -7,6 +7,13 @@ log() {
   echo "[get-postfixed-pouchdb-build] $*"
 }
 
+indexeddb_support() {
+  # indexeddb adapter introduced in v7.2.1
+  # see: https://pouchdb.com/2020/02/12/pouchdb-7.2.0.html
+  lesser="$(sort -V <(echo "$1") <(echo 7.2.1) | head -n1)"
+  [[ "$lesser" = "7.2.1" ]]
+}
+
 # Recently, postfixed JS files have been added in minified form.
 infix=".min"
 while [[ $# -gt 1 ]]; do
@@ -35,4 +42,20 @@ wget "https://github.com/pouchdb/pouchdb/releases/download/$version/pouchdb-${ve
 log "Converting globals..."
 sed "s/PouchDB/PouchDBVersion$nodots/g" "$tmp" > "$target"
 
+log "Checking for indexeddb support..."
+if indexeddb_support "$version"; then
+  log "  indexeddb supported!"
+
+  tmp="$(mktemp)"
+  target="./pouchdb-$version-indexeddb-postfixed.js"
+
+  log "  Fetching indexeddb adapter..."
+  wget "https://github.com/pouchdb/pouchdb/releases/download/$version/pouchdb.indexeddb.min.js" --output-document="$tmp"
+
+  log "  Converting globals..."
+  sed "s/PouchDB/PouchDBVersion$nodots/g" "$tmp" > "$target"
+else
+  echo "  indexeddb not supported by PouchDB v$version"
+fi
+
 log "Completed OK."