Implement _revs_limit #2839

Closed
nolanlawson opened this Issue Oct 8, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@nolanlawson
Member

nolanlawson commented Oct 8, 2014

ala Couch

@anaran

This comment has been minimized.

Show comment
Hide comment
@anaran

anaran Mar 26, 2015

Contributor

Ah, so this might be the reason I cannot restore a previous revision after db.remove(id);
I can get _revisions.ids but all the revs are missing except for the final one, which is ok but has "_deleted": true and no doc fields available.

Contributor

anaran commented Mar 26, 2015

Ah, so this might be the reason I cannot restore a previous revision after db.remove(id);
I can get _revisions.ids but all the revs are missing except for the final one, which is ok but has "_deleted": true and no doc fields available.

@anaran

This comment has been minimized.

Show comment
Hide comment
@anaran

anaran Mar 27, 2015

Contributor

Using doc._deleted = true; db.put(doc); keeps all doc fields intact in the tombstone revision,
just like you said in #pouchdb.

Using db.remove(id); does not!

In both cases the previous revision becomes missing immediately, even without replication or further db activity.

Contributor

anaran commented Mar 27, 2015

Using doc._deleted = true; db.put(doc); keeps all doc fields intact in the tombstone revision,
just like you said in #pouchdb.

Using db.remove(id); does not!

In both cases the previous revision becomes missing immediately, even without replication or further db activity.

@nolanlawson

This comment has been minimized.

Show comment
Hide comment
@nolanlawson

nolanlawson Apr 6, 2015

Member

Using doc._deleted = true; db.put(doc); keeps all doc fields intact in the tombstone revision,
just like you said in #pouchdb.

Using db.remove(id); does not!

This is intended behavior, and will be documented when the docs are updated soon.

Member

nolanlawson commented Apr 6, 2015

Using doc._deleted = true; db.put(doc); keeps all doc fields intact in the tombstone revision,
just like you said in #pouchdb.

Using db.remove(id); does not!

This is intended behavior, and will be documented when the docs are updated soon.

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Nov 14, 2015

Member

Fixed in 5832d03

Member

daleharvey commented Nov 14, 2015

Fixed in 5832d03

@daleharvey daleharvey closed this Nov 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment