Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add androidDatabaseImplementation option for websql #3835

Closed

Conversation

rubensayshi
Copy link
Contributor

this option has been added to the cordova sqlite plugin to fallback to an older sqlite implementation; https://github.com/litehelpers/Cordova-sqlite-storage#android-sqlite-implementation

@nolanlawson
Copy link
Member

It pains me to keep adding hacks like this to support the SQLite Plugin.

That being said, this is a huge issue for people trying to use both libraries together, so I'm +1. Could you also add some documentation to this file to explain the new parameter to people? We should probably also explicitly recommend the "2" implementation, since "1" seems quite broken.

I would also be very happy to see a version of this PR that simply passed all the options in, or merged it into a new options object, so that we don't have to keep whitelisting options as the SQLite Plugin adds them.

@nolanlawson
Copy link
Member

Added some documentation, fixed up the commit message, and merged as 9d1b032.

Whatever works best for our users, I guess we should do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants