Ability to disable Changes feed timeout #4583

Closed
garethbowen opened this Issue Nov 17, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@garethbowen
Member

garethbowen commented Nov 17, 2015

For "live" changes feeds it's useful to be able to disable the timeout altogether. Currently if you pass {timeout:false} this fails a truthy check and the timeout is defaulted. Instead check if a value is set to any value before defaulting.

Disabling the timeout in replication should just work once the Changes implementation is patched. Check that it's working as expected and update the replication documentation.

Prior art for this option is the heartbeat option which takes a number or false to disable.

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Jan 9, 2016

Member

Fixed in 877f298

Member

daleharvey commented Jan 9, 2016

Fixed in 877f298

@daleharvey daleharvey closed this Jan 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment