test.changes.js-http Kill database while listening to live changes #4677

Closed
daleharvey opened this Issue Dec 20, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@daleharvey
Member

daleharvey commented Dec 20, 2015

No description provided.

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Dec 20, 2015

Member

http adapter, complete isnt being called in some cases of the destroy path, looking now

Member

daleharvey commented Dec 20, 2015

http adapter, complete isnt being called in some cases of the destroy path, looking now

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Dec 20, 2015

Member

I have no idea how this can fail, the changes object on setup adds the event listener for destroyed (https://github.com/pouchdb/pouchdb/blob/master/lib/changes.js#L46), this is during the constructor so there is no way it cannot be listening by the time the database gets destroyed, its also never reproduced locally

Member

daleharvey commented Dec 20, 2015

I have no idea how this can fail, the changes object on setup adds the event listener for destroyed (https://github.com/pouchdb/pouchdb/blob/master/lib/changes.js#L46), this is during the constructor so there is no way it cannot be listening by the time the database gets destroyed, its also never reproduced locally

daleharvey added a commit to daleharvey/pouchdb that referenced this issue Dec 20, 2015

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Dec 20, 2015

Member

omg

  1) test.changes.js-http Kill database while listening to live changes:
     Error: Parse Error
      at onError (lib/deps/ajax/ajaxCore.js:52:18)
      at Request._callback (lib/deps/ajax/ajaxCore.js:90:14)
      at self.callback (node_modules/request/request.js:198:22)
      at Request.onRequestError (node_modules/request/request.js:820:8)
      at Socket.socketOnData (_http_client.js:322:9)
      at readableAddChunk (_stream_readable.js:163:16)
      at Socket.Readable.push (_stream_readable.js:126:10)
      at TCP.onread (net.js:540:20)
Member

daleharvey commented Dec 20, 2015

omg

  1) test.changes.js-http Kill database while listening to live changes:
     Error: Parse Error
      at onError (lib/deps/ajax/ajaxCore.js:52:18)
      at Request._callback (lib/deps/ajax/ajaxCore.js:90:14)
      at self.callback (node_modules/request/request.js:198:22)
      at Request.onRequestError (node_modules/request/request.js:820:8)
      at Socket.socketOnData (_http_client.js:322:9)
      at readableAddChunk (_stream_readable.js:163:16)
      at Socket.Readable.push (_stream_readable.js:126:10)
      at TCP.onread (net.js:540:20)
@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Dec 20, 2015

Member

Fixed in 7ede502

Member

daleharvey commented Dec 20, 2015

Fixed in 7ede502

@daleharvey daleharvey closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment