Webpack ignores request-browser.js #4700

Closed
nolanlawson opened this Issue Dec 25, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@nolanlawson
Member

nolanlawson commented Dec 25, 2015

See nolanlawson/pouchdb-async-storage#6 and #4695.

Webpack is trying to browserify request itself instead of using our request-browser.js, which causes failures.

@nolanlawson

This comment has been minimized.

Show comment
Hide comment
@nolanlawson

nolanlawson Dec 25, 2015

Member

Well, I am working on writing a test for Webpack build, and discovering that f95aca6 actually broke Webpack. So it's good we're testing this.

Member

nolanlawson commented Dec 25, 2015

Well, I am working on writing a test for Webpack build, and discovering that f95aca6 actually broke Webpack. So it's good we're testing this.

nolanlawson added a commit that referenced this issue Dec 25, 2015

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Dec 26, 2015

Member

Fixed in e586068

Member

daleharvey commented Dec 26, 2015

Fixed in e586068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment