Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node6 is permafail #5102

Closed
daleharvey opened this issue Apr 27, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@daleharvey
Copy link
Member

commented Apr 27, 2016

All node tests, likely due to the 6x release

@daleharvey

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2016

So https://github.com/pouchdb/pouchdb/blob/master/tests/integration/test.attachments.js#L1268 is failing because the new version of node is generating different digests

daleharvey added a commit that referenced this issue Apr 27, 2016

daleharvey added a commit that referenced this issue Apr 27, 2016

daleharvey added a commit that referenced this issue Apr 27, 2016

daleharvey added a commit that referenced this issue Apr 27, 2016

daleharvey added a commit that referenced this issue Apr 28, 2016

@nolanlawson

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

very confusing since those digests match what's output by both CouchDB and spark-md5. 😕

@nolanlawson

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

might be related: nodejs/node#5522

daleharvey added a commit that referenced this issue Apr 28, 2016

(#5102) - Use LTS node.js for now
(#5102) - Use LTS node.js for now

* (#5102) - Add stable and .10 to allowed failures

* (#5102) - Fix missing body-parser package and do full build

* Try 5?
@daleharvey

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2016

Changed the title since we fixed travis putting it on 5

@daleharvey daleharvey changed the title Travis is permafail node6 is permafail Apr 28, 2016

omsmith added a commit to omsmith/pouchdb that referenced this issue Apr 29, 2016

(pouchdb#5102) - specify md5 data encoding
The default encoding was switched to utf8 in nodejs/node#5522
@omsmith

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2016

Fix for test failures in #5107

You'll also see C/JS stack traces printed until Level/leveldown#280 is available

daleharvey added a commit that referenced this issue Apr 29, 2016

omsmith added a commit to omsmith/pouchdb that referenced this issue Apr 29, 2016

(pouchdb#5102) - specify md5 data encoding
The default encoding was switched to utf8 in nodejs/node#5522

daleharvey added a commit that referenced this issue Apr 29, 2016

(#5102) - Specify md5 data encoding
The default encoding was switched to utf8 in nodejs/node#5522
@daleharvey

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2016

Fixed in 3d7d497

@daleharvey daleharvey closed this Apr 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.