New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating WebSQL #6943

Closed
daleharvey opened this Issue Dec 17, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@daleharvey
Member

daleharvey commented Dec 17, 2017

So happy days, IndexedDB is supported in all major browsers (https://caniuse.com/#search=Indexeddb) and once #6938 lands we will be using it everywhere, meaning webSQL will become legacy code

I suggest we do a 6.4.1 release that purely 6.4.0 + #6938, users who are worried about migrations can then use this release, detect if they have existing webSQL installations and migrate those over to indexedDB

Then at that point, 7.0 can be webSQL free, we can split it out into a new repo as an optional adapter for anyone to use, just not maintained + tested as part of core

@daleharvey daleharvey referenced this issue Dec 17, 2017

Closed

PouchDB 7.0 #6946

8 of 8 tasks complete
@nolanlawson

This comment has been minimized.

Member

nolanlawson commented Jan 7, 2018

#6938 is merged

@nolanlawson

This comment has been minimized.

Member

nolanlawson commented Jan 7, 2018

There's probably no need to split it out into a new repo. Even if we remove it as a dep, running the publish scripts will continue publishing it as an optional dependency, so anyone who wants to use it can. Plus removing all the tangled websql-core / node-websql deps is probably not worth the trouble.

This plan sounds solid to me!

nolanlawson added a commit that referenced this issue Jan 7, 2018

daleharvey added a commit that referenced this issue Jan 25, 2018

(#6943) - Remove WebSQL adapter (BREAKING)
make websql a separate plugin, fix phantomjs tests
@daleharvey

This comment has been minimized.

Member

daleharvey commented Jan 26, 2018

Yeh so while ultimately I would prefer them in a seperate repo, I think thats a bit of a big change to make suddenly, can keep them here for now and close this out, after a couple of release / months can take a look at moving them. Thanks :)

@daleharvey daleharvey closed this Jan 26, 2018

@moses

This comment has been minimized.

moses commented Feb 19, 2018

Hi folks: Since the SQLite Plugin depends on the WebSQL adapter, will native SQLite support be deprecated as well within PouchDB?

Thanks for all that you do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment