Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add BinaryBlob Support for IE11 #1078
referenced this pull request
Dec 2, 2013
I updated the source to do a manual conversion from string to typed array (Uint8Array). This should remove the run-time error.
But this work should really be reviewed by someone who either authored the IDB interface, or the current stake-holder.
Why? I admit my complete ignorance in knowing why there is a special branch for string attachments, and why this is converted to Base64. Perhaps itcould just convert to a typed array and then store as binary blob? Basically, I am saying that the branch I need (binary blob) works just great, but someone who really understands this should look at the global implications.
I will take an extra look at this tomorrow, the api is exposed for people to interchangeably read and write with either blobs or base64, it gets confusing since different backend support different capabilities
Any change on this level will likely hit against something in the tests so if you can get them to run it would really help you, there is docs up @ https://github.com/daleharvey/pouchdb/blob/master/CONTRIBUTING.md and if you have any questions just ask
I agree about the tests, it is just a combination of out firewall and the fact that I have to sit down and learn about node and node packages in depth. I have blocked out a couple of weeks later this month, but I am not there yet, and my initial
Revisiting this, I can confirm that in IE11 the attachments tests do not pass. Annoyingly there's no error message; it just hangs.
In case it facilitates the development process, there's now pouchtest.com, so you don't have to run the dev server yourself. http://pouchtest.com/tests/test.html?testFiles=test.attachments.js will run the attachments test.