Update spark-md5 to version 2.0.0 πŸš€ #4529

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@greenkeeperio-bot
Contributor

greenkeeperio-bot commented Nov 2, 2015

Hello πŸ‘‹

πŸš€πŸš€πŸš€

spark-md5 just published its new version 2.0.0, which is not covered by your current version range.

If this pull request passes your tests you can publish your software with the latest version of spark-md5 – otherwise use this branch to work on adaptions and fixes.

Happy fixing and merging 🌴


The new version differs by 5 commits .

  • 018fee8 Bump version.
  • 80acecd The raw option now returns the raw binary string, similar to PHP and other languages.
  • 32e9e52 Bump version.
  • 9f54482 [fix] Fix incremental hash of array buffers when the buffer had remainings, closes #29.
  • 2124691 Minify.

See the full diff.


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚑️
@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Nov 13, 2015

Member

@satazor hrm, https://github.com/pouchdb/pouchdb/blob/master/lib/deps/md5-browser.js is where we are using spark-md5 and I dont see how we would majorly break due to this, but it seems we have, any ideas of what would be incompatible before I dive in?

Member

daleharvey commented Nov 13, 2015

@satazor hrm, https://github.com/pouchdb/pouchdb/blob/master/lib/deps/md5-browser.js is where we are using spark-md5 and I dont see how we would majorly break due to this, but it seems we have, any ideas of what would be incompatible before I dive in?

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Nov 13, 2015

Member

Oh wait, thats fairly clear, we are converting to binary string on our end as well

Member

daleharvey commented Nov 13, 2015

Oh wait, thats fairly clear, we are converting to binary string on our end as well

@satazor

This comment has been minimized.

Show comment
Hide comment
@satazor

satazor Nov 13, 2015

The only backwards incompatible change was the raw parameter which now returns a binary string instead of an array. So your conversion is no longer necessary.

satazor commented Nov 13, 2015

The only backwards incompatible change was the raw parameter which now returns a binary string instead of an array. So your conversion is no longer necessary.

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Nov 13, 2015

Member

Yup cheers, as a bonus this is also a few bytes smaller :)

Member

daleharvey commented Nov 13, 2015

Yup cheers, as a bonus this is also a few bytes smaller :)

@nickcolley

This comment has been minimized.

Show comment
Hide comment
@nickcolley

nickcolley Nov 14, 2015

Member

πŸ‘ when green :)

Member

nickcolley commented Nov 14, 2015

πŸ‘ when green :)

@daleharvey

This comment has been minimized.

Show comment
Hide comment
@daleharvey

daleharvey Nov 15, 2015

Member

Sweet cheers - cfb2521

Member

daleharvey commented Nov 15, 2015

Sweet cheers - cfb2521

@daleharvey daleharvey closed this Nov 15, 2015

@daleharvey daleharvey deleted the greenkeeper-spark-md5-2.0.0 branch Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment