Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#XXX) - Don't leak change listeners #5450

Merged
merged 1 commit into from Jul 8, 2016

Conversation

@anowak
Copy link
Member

commented Jul 7, 2016

When listener was removed, it still was kept in the internal array. I
don't think there is a sane way of testing this.

When listener was removed, it still was kept in the internal array. I
don't think there is a sane way of testing this.
@daleharvey

This comment has been minimized.

Copy link
Member

commented Jul 8, 2016

Yeh I can see how this is hard to test, its clear enough and a small patch so 👍, thanks

@daleharvey daleharvey merged commit ff27798 into pouchdb:master Jul 8, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
anowak added a commit to evidenceprime/pouchdb that referenced this pull request Jul 13, 2016
When listener was removed, it still was kept in the internal array. I
don't think there is a sane way of testing this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.