Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#6099) - use Map/Set in viewCleanup() #6099

Merged
merged 1 commit into from Jan 4, 2017

Conversation

@nolanlawson
Copy link
Member

commented Jan 3, 2017

One more place where we were unsafely mapping docIds using {} instead of Map/Set...

I should probably add a test to do map/reduce with a doc ID like "constructor" but haven't gotten around to it yet.

@nolanlawson nolanlawson force-pushed the view-cleanup-map-set branch from 22860cd to a72a60d Jan 3, 2017
@nolanlawson

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2017

OK, added a new test.

Copy link
Member

left a comment

Awesome, lets get this in for the release

@daleharvey daleharvey merged commit 77547f7 into master Jan 4, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.