Add checkpoint events during replication #8324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbaHerrerias
force-pushed
the
replication-checkpoint-event
branch
from
2c4477c
to
a30de4d
Compare
|
We have updated eslint |
janl
requested changes
Aug 3, 2021
Co-Authored-By: James Coglan <9265+jcoglan@users.noreply.github.com> Co-Authored-By: Chris E. Kelley <861535+chrisekelley@users.noreply.github.com>
We need to upgrade eslint version in order to use modern JS syntax in tests (like arrow functions or async keyword) Co-Authored-By: James Coglan <9265+jcoglan@users.noreply.github.com>
Co-Authored-By: James Coglan <9265+jcoglan@users.noreply.github.com>
AlbaHerrerias
force-pushed
the
replication-checkpoint-event
branch
from
b766bb9
to
674048a
Compare
janl
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation behind this PR is to emit checkpoint events during the replication process. This PR is related to @chrisekelley 's fork. Our goal is to extract and provide test for these functionalities.
In this PR:
checkpointinside the packagepouchdb-replication.We emit an object, which can contain the following property names:
checkpoint,revs_diff,start_next_batchandpending_batch. Would these followPouchDBvariable name conventions? We will be happy to refactor them if someone comes up with better naming for these.test.replication_events.js, but we are unsure if this is the correct suite to test it.Any help would be highly appreciated. Thank you.