Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix option browser default nil #128

Closed
wants to merge 1 commit into from
Closed

fix option browser default nil #128

wants to merge 1 commit into from

Conversation

iuhoay
Copy link

@iuhoay iuhoay commented Dec 2, 2016 

$ powder open
Expected string default value for '--browser'; got false (boolean)

on ruby 2.3.3, thor 0.19.4

@jstayton
Copy link

jstayton commented Dec 6, 2016

Same fix as #127.

Either way, 👍.

@tannermares
Copy link

👍 Are either of these waiting on anything... warning is SUPER annoying. 😜

@lorcan
Copy link

lorcan commented Feb 18, 2017

Any chance we can get this merged and a new version released?

@mikelovely mikelovely mentioned this pull request Feb 18, 2017
Closed
@fredbaa
Copy link

fredbaa commented Mar 7, 2017

can we have this merged already?

@pusewicz
Copy link

@rodreegez Any update on this?

@kevinelliott
Copy link

Geez, has the project been abandoned?

@philnash philnash mentioned this pull request Jun 13, 2017
Merged
@philnash
Copy link
Collaborator

I've merged #127 which does the same as this.

This now released as version 0.3.1.

Sorry for the unforgivably long delay.

@philnash philnash closed this Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbrawn michaelbrawn michaelbrawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@iuhoay @jstayton @tannermares @lorcan @fredbaa @pusewicz @kevinelliott @philnash @michaelbrawn