New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(espower-source): support file SourceMap #14

Merged
merged 1 commit into from Apr 8, 2017

Conversation

Projects
None yet
2 participants
@shepherdwind
Contributor

shepherdwind commented Apr 8, 2017

If the SourceMap comment refer to a file path, then load sourceMap by fromMapFileComment other than fromComment.

When I use typescript with power-assert, I open the sourceMap config, and then the sourceMap comment refer to a foo.js.map file.

I spend a lot time to find why soucemap just not work, And finally I find that this lib do not support file sourceMap. So I send this pr to fix it.

feat(espower-source): support file SourceMap
If the SourceMap comment refer to a file path, then
load sourceMap by `fromMapFileComment` other than `fromComment`.
@twada

This comment has been minimized.

Show comment
Hide comment
@twada

twada Apr 8, 2017

Member

@shepherdwind Thank you for your great contribution!
I'll release this feature ASAP.

Member

twada commented Apr 8, 2017

@shepherdwind Thank you for your great contribution!
I'll release this feature ASAP.

@twada twada merged commit bc722da into power-assert-js:master Apr 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@twada

This comment has been minimized.

Show comment
Hide comment
@twada

twada Apr 9, 2017

Member

espower-source 2.1.0 is out. Thanks!

Member

twada commented Apr 9, 2017

espower-source 2.1.0 is out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment