Big Restructuring: Canonical Assertion #8

merged 20 commits into from May 2, 2014


None yet
1 participant

twada commented Apr 30, 2014

Generate canonical assertion expression from JavaScript AST instead of searching/splitting JavaScript source code.

This feature enables us to instrument power-assert feature even if target assertion expression contains multiple lines. Therefore, Embedded AST feature is not required any more.


  • Design again
  • Spike
  • Move escodegen to runtime dependency to generate canonical expression
  • Generate canonical expression instead of searched lines
  • Remove Embedded AST feature
  • Move esprima to development dependency since Embedded AST feature is gone
  • Ignore lineSeparator option
  • Ignore source option
  • Capture espath at assertion expression level
  • Use raw literal value for saved assertion content
  • More tests
  • Detect line number using Node loc
  • Refactoring
  • Update dependencies
  • Prepare for next minor release

@twada twada self-assigned this May 1, 2014

@twada twada changed the title from [WIP] Big Restructuring: Canonical Assertion to Big Restructuring: Canonical Assertion May 2, 2014

twada added a commit that referenced this pull request May 2, 2014

Merge pull request #8 from twada/canonical_assertion
Big Restructuring: Canonical Assertion

@twada twada merged commit 0c31aec into master May 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed

@twada twada deleted the canonical_assertion branch May 2, 2014

@twada twada referenced this pull request in power-assert-js/power-assert May 12, 2014


Release 0.7.0 #7

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment