Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Restructuring: Canonical Assertion #8

Merged
merged 20 commits into from May 2, 2014
Merged

Big Restructuring: Canonical Assertion #8

merged 20 commits into from May 2, 2014

Conversation

@twada
Copy link
Member

twada commented Apr 30, 2014

Generate canonical assertion expression from JavaScript AST instead of searching/splitting JavaScript source code.

This feature enables us to instrument power-assert feature even if target assertion expression contains multiple lines. Therefore, Embedded AST feature is not required any more.

TODO

  • Design again
  • Spike
  • Move escodegen to runtime dependency to generate canonical expression
  • Generate canonical expression instead of searched lines
  • Remove Embedded AST feature
  • Move esprima to development dependency since Embedded AST feature is gone
  • Ignore lineSeparator option
  • Ignore source option
  • Capture espath at assertion expression level
  • Use raw literal value for saved assertion content
  • More tests
  • Detect line number using Node loc
  • Refactoring
  • Update dependencies
  • Prepare for next minor release
@twada twada self-assigned this May 1, 2014
@twada twada changed the title [WIP] Big Restructuring: Canonical Assertion Big Restructuring: Canonical Assertion May 2, 2014
twada added a commit that referenced this pull request May 2, 2014
Big Restructuring: Canonical Assertion
@twada twada merged commit 0c31aec into master May 2, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@twada twada deleted the canonical_assertion branch May 2, 2014
@twada twada mentioned this pull request May 12, 2014
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.