Skip to content

build(create): use bulk-require to import built-in renederers. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

build(create): use bulk-require to import built-in renederers. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ gulp.task('clean_coverage', function (done) {

gulp.task('bundle', ['clean_bundle'], function() {
var b = browserify({entries: config.bundle.srcFile, standalone: config.bundle.standalone});
b.transform('bulkify');
b.plugin(licensify);
var bundleStream = b.bundle();
return bundleStream
Expand Down
35 changes: 14 additions & 21 deletions lib/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,19 @@ var defaultOptions = require('./default-options');
var typeName = require('type-name');
var extend = require('xtend');
var map = require('array-map');
var mapObj = require('map-obj');
var camelCase = require('camelcase');

var AssertionRenderer = require('./built-in/assertion');
var FileRenderer = require('./built-in/file');
var DiagramRenderer = require('./built-in/diagram');
var BinaryExpressionRenderer = require('./built-in/binary-expression');

// "Browserify can only analyze static requires. It is not in the scope of browserify to handle dynamic requires."
// https://github.com/substack/node-browserify/issues/377
var defaultRendererClasses = {
'./built-in/file': FileRenderer,
'./built-in/assertion': AssertionRenderer,
'./built-in/diagram': DiagramRenderer,
'./built-in/binary-expression': BinaryExpressionRenderer
};
var builtin = require('bulk-require')(__dirname, ['built-in/*.js'])['built-in'];

function toRendererClass (rendererName) {
var RendererClass;
if (typeName(rendererName) === 'function') {
RendererClass = rendererName;
} else if (typeName(rendererName) === 'string') {
if (defaultRendererClasses[rendererName]) {
RendererClass = defaultRendererClasses[rendererName];
var match = /^\.\/built-in\/(.*?)(?:\.js)?$/.exec(rendererName);
if (match && builtin[match[1]]) {
RendererClass = builtin[match[1]];
} else {
RendererClass = require(rendererName);
}
Expand Down Expand Up @@ -80,12 +71,14 @@ function create (options) {
};
}

create.renderers = {
AssertionRenderer: AssertionRenderer,
FileRenderer: FileRenderer,
DiagramRenderer: DiagramRenderer,
BinaryExpressionRenderer: BinaryExpressionRenderer
};
function capitalize(str) {
return str[0].toUpperCase() + str.substring(1);
}

create.renderers = mapObj(builtin, function (key, val) {
return [capitalize(camelCase(key)) + 'Renderer', val];
});

create.defaultOptions = defaultOptions;
create.stringWidth = stringWidth;
module.exports = create;
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@
"array-foreach": "^1.0.1",
"array-map": "0.0.0",
"array-reduce": "0.0.0",
"bulk-require": "^0.2.1",
"camelcase": "^1.2.1",
"eastasianwidth": "^0.1.0",
"esprima": "^2.5.0",
"estraverse": "^4.1.0",
"googlediff": "^0.1.0",
"map-obj": "^1.0.1",
"object-keys": "^1.0.4",
"stringifier": "^1.2.0",
"type-name": "^1.0.1",
Expand All @@ -35,6 +38,7 @@
"blanket": "^1.1.7",
"bluebird": "^3.0.5",
"browserify": "^11.0.1",
"bulkify": "^1.1.1",
"del": "^1.2.1",
"empower": "^1.0.0",
"escodegen": "^1.6.1",
Expand Down