Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated user css file #1435

Merged
merged 3 commits into from Apr 19, 2021
Merged

Updated user css file #1435

merged 3 commits into from Apr 19, 2021

Conversation

christinaatai
Copy link
Contributor

@christinaatai christinaatai commented Apr 5, 2021

Screens

Before
Screen Shot 2021-04-05 at 12 11 54 PM

After
Screen Shot 2021-04-05 at 12 22 15 PM

Old NavItem Block doc example
Screen Shot 2021-04-05 at 2 04 19 PM

New NavItem Block doc example
Screen Shot 2021-04-05 at 2 03 56 PM

Breaking Changes

No –– this PR only affects the CSS class in User Kit.

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/NUXE-584

How to test this

I tested this bug by updating the doc example so that a User Kit is in Nav/NavItem to confirm that the styling is behaving as expected.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • URGENCY Please select a release milestone
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

The normal release cut off deadline is 3p EDT each week. Please reach out to the release team if you have an urgent request or need a release off cycle.

@christinaatai christinaatai requested a review from a team as a code owner April 5, 2021 17:39
@christinaatai christinaatai self-assigned this Apr 5, 2021
@christinaatai christinaatai added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Apr 5, 2021
@christinaatai christinaatai added this to the Future Release TBD milestone Apr 5, 2021
Copy link
Contributor

@bh247484 bh247484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jasoncypret
Copy link
Member

@powerhome/ux-team This can go right into a master. No need for an alpha

@jasoncypret jasoncypret added enhancement New Features, Props, & Variants (USED IN CHANGELOG) Ready for Release merged to master, ready for a versioned released and removed bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) labels Apr 16, 2021
@jasoncypret jasoncypret merged commit 2e63006 into master Apr 19, 2021
@jasoncypret jasoncypret deleted the user-kit-bug branch April 19, 2021 16:11
@kre8sions kre8sions removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants