Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-706] Adding xxs to Flex gap, column gap and row gap #2423

Merged
merged 3 commits into from Apr 4, 2023
Merged

[PLAY-706] Adding xxs to Flex gap, column gap and row gap #2423

merged 3 commits into from Apr 4, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Apr 4, 2023

Screens

Screenshot 2023-04-04 at 6 28 19 AM

Breaking Changes

No

Runway Ticket URL

RUNWAY STORY

How to test this

Made gap xxs on doc example for both react and rails for testing

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Apr 4, 2023
@nidaqg nidaqg requested a review from a team as a code owner April 4, 2023 10:31
@nidaqg nidaqg self-assigned this Apr 4, 2023
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Apr 4, 2023
@nidaqg nidaqg added this pull request to the merge queue Apr 4, 2023
Merged via the queue into master with commit 0af52e1 Apr 4, 2023
5 checks passed
@nidaqg nidaqg deleted the PLAY-706-flex-gapto-accept-xxs branch April 4, 2023 17:36
carloslimasd pushed a commit that referenced this pull request Apr 5, 2023
@nidaqg @carloslimasd
[PLAY-706] Adding xxs to Flex gap, column gap and row gap (#2423)
583a747 
#### Screens

![Screenshot 2023-04-04 at 6 28 19
AM](https://user-images.githubusercontent.com/73710701/229764755-a548c5cc-8959-4377-a187-12c1740b2449.png)

#### Breaking Changes

No

#### Runway Ticket URL

[RUNWAY STORY](https://nitro.powerhrg.com/runway/backlog_items/PLAY-706)

#### How to test this

Made gap xxs on doc example for both react and rails for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nidaqg nidaqg

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nidaqg @jasperfurniss