[GOG-24] Sets image ready build status for milano compatibility #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangfeld
reviewed
Dec 4, 2019
Co-Authored-By: Ben Langfeld <blangfeld@powerhrg.com>
benlangfeld
requested changes
Dec 4, 2019
Jenkinsfile
Outdated
| sh "docker build -t ${appImage} ." | ||
| sh "docker push ${appImage}" | ||
| try { | ||
| github.setImageBuildState(scmVars.GIT_COMMIT, scmVars.GIT_URL, 'PENDING') |
There was a problem hiding this comment.
This fails:
ERROR: [GitHub Commit Status Setter] Failed to update commit state on GitHub. Ignoring exception [{"message":"No commit found for SHA: f3c81b0970facf9abc8a4663b008eeea55025d46","documentation_url":"https://developer.github.com/v3/repos/statuses/#create-a-status"}]
There was a problem hiding this comment.
Seems to be working now
jasoncypret
approved these changes
Dec 4, 2019
thestephenmarshall
approved these changes
Dec 4, 2019
benlangfeld
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
ci-kubedto set the image ready status check.