-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for maintainers #2012
Comments
I haven't used powerline myself for years, so a lack of interest is the main reason I haven't been contributing to it. I'd be happy to add contributors to the main repo if anyone is up for the task. |
I'd be happy to help. |
Thanks. @ZyX-I Any thoughts? |
I'm interested but I do object to how slow powerline runs, so would probably takes things in a different direction. EDIT: I'm very interested @Lokaltog would be great to have some discussion with the current maintainers, or even a statement about what they would like to see. If the focus is purely "we just want updates so powerline doesn't break with new versions of each dependency" I'm moderately interested, but if "we just want powerline to be faster and to see ever more people have awesome looking and awesome working shell environments", then it's definitely something that I'm passionate about. |
I agree with @ryanerwin; and I am interested in contributing too. |
@ryanerwin I'm not using powerline myself and haven't used it for many years, so I'm not sure what state the project is currently in, and I don't really have any opinions on where it should go in the future. I'm also not sure what to do with this repo, I've considered archiving it and leaving it up to the community to maintain a fork to avoid another event-stream situation. But since this would probably kill the repo I'll instead add you guys to a maintaner team and try to follow up on the development for a while. |
I took a look at this code ~1.5 years ago, but then somehow lost interest for it. Regarding the future direction, I'm having some issues with the current CI environment, as this is giving ~5k lines of output, but most of it seems to be non relevant bash output and it's not really clear why tests are failing and how they are exactly failing. Don't get me wrong, I like the fact that this repository has this huge amount of tests, but redoing the test execution workflow could benefit to the readability. Also I'm not a huge fan of the current installation and configuration workflow, all of this seems to be tedious and error-prone. I am often getting some errors when configuring powerline without having a clue why this happens. Also JSON is in my opinion exceptionally bad for configuration files as it does not support comments (if you don't add them like VSCode did it). |
@StopMotionCuber Json5 supports comments, so maybe the project could just change to reading the config files with json5. Although the dev says it's super slow (and as far as I can see, the configs are read often and not just on startup?). |
I don't think rewriting powerline to use a different configuration is really needed (although comments would indeed be nice; perhaps we could use fields starting with an underscore for that, that are then ignored by powerline):
Regarding the tests, I agree with @StopMotionCuber though: Navigating to a failing test case is a pain; some test cases sometimes fail for no obvious reason, etc... However, again, rewriting this is probably a lot of work. |
For what it's worth, switching to using YAML for configuration would add support for comments, and IMHO more readable syntax (assuming you're ok with indentation that matters). Since YAML is a superset of JSON, all current configuration files are already valid YAML, and the changes in the code would be minimal. Probably as easy as accept a couple additional file extensions, and using |
There seem to be issues and pull requests piling up in the past 9 months of no merges or commits.
It's understandable that the current maintainer, @Lokaltog, might be busy, but can you please share or transfer maintenance responsibilities? Perhaps @PH111P of the most active fork might be willing.
Many people use this for their daily productivity, and lack of active maintenance is a bit of a frustration.
The text was updated successfully, but these errors were encountered: