New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with oh-my-zsh (port as a theme) #390

Closed
barraponto opened this Issue Apr 3, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@barraponto

I'm curious to how to implement this. Right now I'm using https://github.com/jeremyFreeAgent/oh-my-zsh-powerline-theme to integrate powerline into oh-my-zsh, but I'd expect a proper theme to be developed within this repo (to keep with the powerline unification).

@Lokaltog

This comment has been minimized.

Show comment
Hide comment
@Lokaltog

Lokaltog Apr 4, 2013

Member

Currently we have support for zsh prompts, although the default one doesn't look exactly the same as the oh-my-zsh theme. I've been thinking about using unicode chars for repo status, but there's been a couple of performance issues with big repos which has prevented this from being implemented.

I'm not sure what your question is, if you're just looking for a prompt you can check out the docs on how to enable it in your zshrc.

Member

Lokaltog commented Apr 4, 2013

Currently we have support for zsh prompts, although the default one doesn't look exactly the same as the oh-my-zsh theme. I've been thinking about using unicode chars for repo status, but there's been a couple of performance issues with big repos which has prevented this from being implemented.

I'm not sure what your question is, if you're just looking for a prompt you can check out the docs on how to enable it in your zshrc.

@barraponto

This comment has been minimized.

Show comment
Hide comment
@barraponto

barraponto Apr 4, 2013

What I'm saying is that it would be very useful to have an oh-my-zsh theme that works out-of-the-box with oh-my-zsh (with proper linking/sourcing of course) and that we, oh-my-zsh users, could tweak and adapt.

It's a small feature request to avoid creating another repo, since powerline is now centralizing all powerline-related development.

What I'm saying is that it would be very useful to have an oh-my-zsh theme that works out-of-the-box with oh-my-zsh (with proper linking/sourcing of course) and that we, oh-my-zsh users, could tweak and adapt.

It's a small feature request to avoid creating another repo, since powerline is now centralizing all powerline-related development.

@Lokaltog

This comment has been minimized.

Show comment
Hide comment
@Lokaltog

Lokaltog Apr 4, 2013

Member

If you're thinking about including it like these themes I think it would be better to contact the authors of oh-my-zsh. It's pretty simple to use Powerline for a prompt, check out the existing zsh bindings. I suppose you could create a oh-my-zsh theme by just including these two lines in a theme file, which will set both the prompt and the right prompt.

Still not sure if I understand the issue correctly, if you rather want me to include a theme in the Powerline repo, just branch off and submit a pull request and I'd be happy to merge it.

Member

Lokaltog commented Apr 4, 2013

If you're thinking about including it like these themes I think it would be better to contact the authors of oh-my-zsh. It's pretty simple to use Powerline for a prompt, check out the existing zsh bindings. I suppose you could create a oh-my-zsh theme by just including these two lines in a theme file, which will set both the prompt and the right prompt.

Still not sure if I understand the issue correctly, if you rather want me to include a theme in the Powerline repo, just branch off and submit a pull request and I'd be happy to merge it.

@ZyX-I ZyX-I closed this Jan 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment