Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #958 convert constructors of nested classes to public as well #978

Merged
merged 2 commits into from Apr 21, 2019

Conversation

Projects
None yet
2 participants
@sam-ma
Copy link
Contributor

commented Mar 8, 2019

This is a potential fix for issue #958 which I currently experienced as well. I think the issue is due to JEP181 JDK11 stops creating special access method for nested classes. In addition, classes go through the transformer chain one by one, which means there are chances (I'm not sure how the order is determined, alphabet order?) the nest host class (OuterClass in the test case) passes through the chain before the nest member class (InnerSingleton in the test case). In that case, the constructor is still private which caused the compilation error.

@sam-ma

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

I have created a test project for jdk11 which obviously requires jdk11. I guess that's why checks failed. Not sure how I can fix this.

@thekingnothing thekingnothing merged commit be38fb2 into powermock:release/2.x Apr 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.