From 586db9ae28ce185b10a22108a98b6e65606c9917 Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Wed, 26 Feb 2025 07:52:37 +0200 Subject: [PATCH 01/10] add .vale.ini and keywords --- .github/vale/config/vocabularies/Keywords/accept.txt | 1 + .vale.ini | 12 ++++++++++++ 2 files changed, 13 insertions(+) create mode 100644 .github/vale/config/vocabularies/Keywords/accept.txt create mode 100644 .vale.ini diff --git a/.github/vale/config/vocabularies/Keywords/accept.txt b/.github/vale/config/vocabularies/Keywords/accept.txt new file mode 100644 index 00000000..cad5a040 --- /dev/null +++ b/.github/vale/config/vocabularies/Keywords/accept.txt @@ -0,0 +1 @@ +Supabase \ No newline at end of file diff --git a/.vale.ini b/.vale.ini new file mode 100644 index 00000000..17a75678 --- /dev/null +++ b/.vale.ini @@ -0,0 +1,12 @@ +StylesPath = .github/vale +Vocab = Keywords + +[formats] +mdx = md + +[*] +BasedOnStyles = Vale +Vale.Spelling = YES + +# Ignore generated files +[!{**/node_modules/**,**/dist/**,**/.git/**}] From 7e529e4fb5e4f05f4816d31f9a66deb40c1b58e9 Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Wed, 26 Feb 2025 09:06:56 +0200 Subject: [PATCH 02/10] update vale config and add keywords --- .../config/vocabularies/General/accept.txt | 18 ++++++++++++++++++ .../config/vocabularies/Keywords/accept.txt | 1 - .../vocabularies/Technologies/accept.txt | 13 +++++++++++++ .vale.ini | 5 +++-- 4 files changed, 34 insertions(+), 3 deletions(-) create mode 100644 .github/vale/config/vocabularies/General/accept.txt delete mode 100644 .github/vale/config/vocabularies/Keywords/accept.txt create mode 100644 .github/vale/config/vocabularies/Technologies/accept.txt diff --git a/.github/vale/config/vocabularies/General/accept.txt b/.github/vale/config/vocabularies/General/accept.txt new file mode 100644 index 00000000..09528367 --- /dev/null +++ b/.github/vale/config/vocabularies/General/accept.txt @@ -0,0 +1,18 @@ +SDK +SDKs +VPC +VPCs +ORM +ORMs +IPs +JWT +JWTs +[Dd]ev +[Ss]ubnet +[Ss]ubnets +[Hh]ostname +[Cc]onfig +[Ss]erverless +[Ff]ailover +[Ss]chemaless +[Ss]harded diff --git a/.github/vale/config/vocabularies/Keywords/accept.txt b/.github/vale/config/vocabularies/Keywords/accept.txt deleted file mode 100644 index cad5a040..00000000 --- a/.github/vale/config/vocabularies/Keywords/accept.txt +++ /dev/null @@ -1 +0,0 @@ -Supabase \ No newline at end of file diff --git a/.github/vale/config/vocabularies/Technologies/accept.txt b/.github/vale/config/vocabularies/Technologies/accept.txt new file mode 100644 index 00000000..664d6051 --- /dev/null +++ b/.github/vale/config/vocabularies/Technologies/accept.txt @@ -0,0 +1,13 @@ +Power[Ss]ync +Supabase +Postgres +Coolify +Netlify +Vue +Kotlin +Multiplatform +Kysely +Stytch +Xcode +Cocoapods +MySQL \ No newline at end of file diff --git a/.vale.ini b/.vale.ini index 17a75678..679de1d6 100644 --- a/.vale.ini +++ b/.vale.ini @@ -1,12 +1,13 @@ StylesPath = .github/vale -Vocab = Keywords +Vocab = General, Technologies [formats] mdx = md -[*] +[*.md] BasedOnStyles = Vale Vale.Spelling = YES +CommentDelimiters = {/*, */} # Ignore generated files [!{**/node_modules/**,**/dist/**,**/.git/**}] From 583c701d52b600617dc85be92e0058f6e2e849b5 Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Wed, 26 Feb 2025 09:15:24 +0200 Subject: [PATCH 03/10] update vale keywords --- .github/vale/config/vocabularies/General/accept.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/vale/config/vocabularies/General/accept.txt b/.github/vale/config/vocabularies/General/accept.txt index 09528367..98315e96 100644 --- a/.github/vale/config/vocabularies/General/accept.txt +++ b/.github/vale/config/vocabularies/General/accept.txt @@ -1,5 +1,7 @@ SDK SDKs +API +APIs VPC VPCs ORM From 4e6df98e336047b8cda47f70cc5f6517fbef2d33 Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Wed, 26 Feb 2025 09:20:50 +0200 Subject: [PATCH 04/10] add ignore scopes to vale --- .vale.ini | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.vale.ini b/.vale.ini index 679de1d6..08064640 100644 --- a/.vale.ini +++ b/.vale.ini @@ -1,5 +1,7 @@ StylesPath = .github/vale Vocab = General, Technologies +IgnoredScopes = code, tt, img, url, a +SkippedScopes = script, style, pre [formats] mdx = md From a542a04b28abbaccbb09c197bc36169bbbb68f38 Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Wed, 26 Feb 2025 10:26:55 +0200 Subject: [PATCH 05/10] update vale keywords and add MDX package --- .github/vale/.vale-config/0-MDX.ini | 21 ++++++++++ .../config/vocabularies/General/accept.txt | 20 --------- .../vocabularies/Technologies/accept.txt | 13 ------ .../vale/config/vocabularies/Terms/accept.txt | 41 +++++++++++++++++++ .vale.ini | 16 +++----- 5 files changed, 67 insertions(+), 44 deletions(-) create mode 100644 .github/vale/.vale-config/0-MDX.ini delete mode 100644 .github/vale/config/vocabularies/General/accept.txt delete mode 100644 .github/vale/config/vocabularies/Technologies/accept.txt create mode 100644 .github/vale/config/vocabularies/Terms/accept.txt diff --git a/.github/vale/.vale-config/0-MDX.ini b/.github/vale/.vale-config/0-MDX.ini new file mode 100644 index 00000000..d1f1a54d --- /dev/null +++ b/.github/vale/.vale-config/0-MDX.ini @@ -0,0 +1,21 @@ +[formats] +mdx = md + +[*.mdx] +CommentDelimiters = {/*, */} + +# Exclude: +# +# `import ...`, `export ...` +# `` +# `...` +# `{ ... }` +TokenIgnores = (?sm)((?:import|export) .+?$), \ +(?)(?!`), \ +(<[A-Z]\w+>.+?<\/[A-Z]\w+>) + +# Exclude: +# +# `` +BlockIgnores = (?sm)^(<\w+\n .*\s\/>)$, \ +(?sm)^({.+.*}) diff --git a/.github/vale/config/vocabularies/General/accept.txt b/.github/vale/config/vocabularies/General/accept.txt deleted file mode 100644 index 98315e96..00000000 --- a/.github/vale/config/vocabularies/General/accept.txt +++ /dev/null @@ -1,20 +0,0 @@ -SDK -SDKs -API -APIs -VPC -VPCs -ORM -ORMs -IPs -JWT -JWTs -[Dd]ev -[Ss]ubnet -[Ss]ubnets -[Hh]ostname -[Cc]onfig -[Ss]erverless -[Ff]ailover -[Ss]chemaless -[Ss]harded diff --git a/.github/vale/config/vocabularies/Technologies/accept.txt b/.github/vale/config/vocabularies/Technologies/accept.txt deleted file mode 100644 index 664d6051..00000000 --- a/.github/vale/config/vocabularies/Technologies/accept.txt +++ /dev/null @@ -1,13 +0,0 @@ -Power[Ss]ync -Supabase -Postgres -Coolify -Netlify -Vue -Kotlin -Multiplatform -Kysely -Stytch -Xcode -Cocoapods -MySQL \ No newline at end of file diff --git a/.github/vale/config/vocabularies/Terms/accept.txt b/.github/vale/config/vocabularies/Terms/accept.txt new file mode 100644 index 00000000..5e0f07f1 --- /dev/null +++ b/.github/vale/config/vocabularies/Terms/accept.txt @@ -0,0 +1,41 @@ +SDK +SDKs +API +APIs +VPC +VPCs +CRDT +CRDTs +ORM +ORMs +IPs +JWT +JWTs +[Dd]ev +[Ss]ubnet +[Ss]ubnets +[Hh]ostname +[Cc]onfig +[Ss]erverless +[Ff]ailover +[Ss]chemaless +[Ss]harded +Power[Ss]ync +Supabase +Postgres +Coolify +Netlify +Vue +Kotlin +[Mm]ultiplatform +Kysely +Stytch +Xcode +Cocoapods +MySQL +ngrok +binlog +Tauri +Shadcn +Jepsen +repo \ No newline at end of file diff --git a/.vale.ini b/.vale.ini index 08064640..799194a1 100644 --- a/.vale.ini +++ b/.vale.ini @@ -1,15 +1,9 @@ StylesPath = .github/vale -Vocab = General, Technologies -IgnoredScopes = code, tt, img, url, a -SkippedScopes = script, style, pre +MinAlertLevel = suggestion -[formats] -mdx = md +Packages = MDX -[*.md] -BasedOnStyles = Vale -Vale.Spelling = YES -CommentDelimiters = {/*, */} +Vocab = Terms -# Ignore generated files -[!{**/node_modules/**,**/dist/**,**/.git/**}] +[*] +BasedOnStyles = Vale From 83b6c9f37679b3afac4e5e6f2468511ebd2547ad Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Wed, 26 Feb 2025 11:11:25 +0200 Subject: [PATCH 06/10] update vale config and make keywords case-insensitive --- .github/vale/.vale-config/0-MDX.ini | 21 ----- .../vale/config/vocabularies/Terms/accept.txt | 82 +++++++++---------- .vale.ini | 16 +++- 3 files changed, 53 insertions(+), 66 deletions(-) delete mode 100644 .github/vale/.vale-config/0-MDX.ini diff --git a/.github/vale/.vale-config/0-MDX.ini b/.github/vale/.vale-config/0-MDX.ini deleted file mode 100644 index d1f1a54d..00000000 --- a/.github/vale/.vale-config/0-MDX.ini +++ /dev/null @@ -1,21 +0,0 @@ -[formats] -mdx = md - -[*.mdx] -CommentDelimiters = {/*, */} - -# Exclude: -# -# `import ...`, `export ...` -# `` -# `...` -# `{ ... }` -TokenIgnores = (?sm)((?:import|export) .+?$), \ -(?)(?!`), \ -(<[A-Z]\w+>.+?<\/[A-Z]\w+>) - -# Exclude: -# -# `` -BlockIgnores = (?sm)^(<\w+\n .*\s\/>)$, \ -(?sm)^({.+.*}) diff --git a/.github/vale/config/vocabularies/Terms/accept.txt b/.github/vale/config/vocabularies/Terms/accept.txt index 5e0f07f1..a6d511de 100644 --- a/.github/vale/config/vocabularies/Terms/accept.txt +++ b/.github/vale/config/vocabularies/Terms/accept.txt @@ -1,41 +1,41 @@ -SDK -SDKs -API -APIs -VPC -VPCs -CRDT -CRDTs -ORM -ORMs -IPs -JWT -JWTs -[Dd]ev -[Ss]ubnet -[Ss]ubnets -[Hh]ostname -[Cc]onfig -[Ss]erverless -[Ff]ailover -[Ss]chemaless -[Ss]harded -Power[Ss]ync -Supabase -Postgres -Coolify -Netlify -Vue -Kotlin -[Mm]ultiplatform -Kysely -Stytch -Xcode -Cocoapods -MySQL -ngrok -binlog -Tauri -Shadcn -Jepsen -repo \ No newline at end of file +(?i)sdk +(?i)sdks +(?i)api +(?i)apis +(?i)vpc +(?i)vpcs +(?i)crdt +(?i)crdts +(?i)orm +(?i)orms +(?i)ips +(?i)jwt +(?i)jwts +(?i)dev +(?i)subnet +(?i)subnets +(?i)hostname +(?i)config +(?i)serverless +(?i)failover +(?i)schemaless +(?i)sharded +(?i)powersync +(?i)supabase +(?i)postgres +(?i)coolify +(?i)netlify +(?i)vue +(?i)kotlin +(?i)multiplatform +(?i)kysely +(?i)stytch +(?i)xcode +(?i)cocoapods +(?i)mysql +(?i)ngrok +(?i)binlog +(?i)tauri +(?i)shadcn +(?i)jepsen +(?i)repo \ No newline at end of file diff --git a/.vale.ini b/.vale.ini index 799194a1..1a21acb1 100644 --- a/.vale.ini +++ b/.vale.ini @@ -1,9 +1,17 @@ StylesPath = .github/vale MinAlertLevel = suggestion +Vocab = Terms -Packages = MDX +[formats] +mdx = md -Vocab = Terms +[*.mdx] +BasesOnStyles = Vale +Vale.Spelling = YES -[*] -BasedOnStyles = Vale +CommentDelimiters = {/*, */} +TokenIgnores = (?sm)((?:import|export) .+?$), \ +(?)(?!`), \ +(<[A-Z]\w+>.+?<\/[A-Z]\w+>) +BlockIgnores = (?sm)^(<\w+\n .*\s\/>)$, \ +(?sm)^({.+.*}) From 45b6dd7cddfed9cece32638917896e4af4ff134d Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Wed, 26 Feb 2025 11:30:38 +0200 Subject: [PATCH 07/10] update vale config --- .vale.ini | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.vale.ini b/.vale.ini index 1a21acb1..54adb6fd 100644 --- a/.vale.ini +++ b/.vale.ini @@ -1,6 +1,8 @@ StylesPath = .github/vale MinAlertLevel = suggestion Vocab = Terms +IgnoredScopes = code, tt +SkippedScopes = script, style, pre [formats] mdx = md @@ -8,10 +10,12 @@ mdx = md [*.mdx] BasesOnStyles = Vale Vale.Spelling = YES - CommentDelimiters = {/*, */} + TokenIgnores = (?sm)((?:import|export) .+?$), \ (?)(?!`), \ (<[A-Z]\w+>.+?<\/[A-Z]\w+>) + BlockIgnores = (?sm)^(<\w+\n .*\s\/>)$, \ -(?sm)^({.+.*}) +(?sm)^({.+.*}), \ +(?sm)^(\x60\x60\x60[\w ]*\n.*\x60\x60\x60)$ From a2f13e3ff513f5122df76abb6f2fd99d92790961 Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Tue, 11 Mar 2025 07:09:11 +0200 Subject: [PATCH 08/10] update vale config with Mintlify defaults and add more terms --- .../config/vocabularies/Mintlify/accept.txt | 267 ++++++++++++++++++ .../config/vocabularies/PowerSync/accept.txt | 113 ++++++++ .../vale/config/vocabularies/Terms/accept.txt | 41 --- .vale.ini | 24 +- 4 files changed, 395 insertions(+), 50 deletions(-) create mode 100644 .github/vale/config/vocabularies/Mintlify/accept.txt create mode 100644 .github/vale/config/vocabularies/PowerSync/accept.txt delete mode 100644 .github/vale/config/vocabularies/Terms/accept.txt diff --git a/.github/vale/config/vocabularies/Mintlify/accept.txt b/.github/vale/config/vocabularies/Mintlify/accept.txt new file mode 100644 index 00000000..8c1e0696 --- /dev/null +++ b/.github/vale/config/vocabularies/Mintlify/accept.txt @@ -0,0 +1,267 @@ +Mintlify +mintlify +VSCode +openapi +OpenAPI +Github +APIs + +repo +npm +dev + +Lorem +ipsum +impsum +amet + +const +myName +myObject +bearerAuth +favicon +topbar +url +borderRadius +args +modeToggle +ModeToggle +isHidden +autoplay + +_italic_ +Strikethrough +Blockquotes +Blockquote +Singleline +Multiline + +onboarding + +async +await +boolean +enum +func +impl +init +instanceof +typeof +params +stdin +stdout +stderr +stdout +stdin +var +const +let +null +undefined +struct +bool + +cors +csrf +env +xhr +xhr2 +jwt +oauth +websocket +localhost +middleware +runtime +webhook +stdin +stdout + +json +yaml +yml +md +txt +tsx +jsx +css +scss +html +png +jpg +svg + +cdn +cli +css +dom +dto +env +git +gui +http +https +ide +jvm +mvc +orm +rpc +sdk +sql +ssh +ssl +tcp +tls +uri +url +ux +ui + +nodejs +npm +yarn +pnpm +eslint +pytest +golang +rustc +kubectl +mongo +postgres +redis + +JavaScript +TypeScript +Python +Ruby +Rust +Go +Golang +Java +Kotlin +Swift +Node.js +NodeJS +Deno + +React +Vue +Angular +Next.js +Nuxt +Express +Django +Flask +Spring +Laravel +Redux +Vuex +TensorFlow +PostgreSQL +MongoDB +Redis +PNPM + +Docker +Kubernetes +AWS +Azure +GCP +Terraform +Jenkins +CircleCI +GitLab +Heroku + +Git +git +GitHub +GitLab +Bitbucket +VSCode +Visual Studio Code +IntelliJ +WebStorm +ESLint +eslint +Prettier +prettier +Webpack +webpack +Vite +vite +Babel +babel +Jest +jest +Mocha +Cypress +Postman + +HTTP +HTTPS +OAuth +JWT +GraphQL +REST +WebSocket +TCP/IP + +NPM +Yarn +PNPM +Pip +PIP +Cargo +RubyGems + +Swagger +OpenAPI +Markdown +MDX +Storybook +TypeDoc +JSDoc + +MySQL +PostgreSQL +MongoDB +Redis +Elasticsearch +DynamoDB + +Linux +Unix +macOS +iOS + +Firefox +Chromium +WebKit + +config +ctx +desc +dir +elem +err +len +msg +num +obj +prev +proc +ptr +req +res +str +tmp +val +vars + +todo +href +lang +nav +prev +next +toc \ No newline at end of file diff --git a/.github/vale/config/vocabularies/PowerSync/accept.txt b/.github/vale/config/vocabularies/PowerSync/accept.txt new file mode 100644 index 00000000..8f1ff992 --- /dev/null +++ b/.github/vale/config/vocabularies/PowerSync/accept.txt @@ -0,0 +1,113 @@ +# Terms +dev +subnet +subnets +hostname +config +serverless +failover +schemaless +sharded +binlog +walkthrough +denormalize +defragment +defragmenting +defragmentation +wifi +polyfill +polyfills +agnostically +websockets +uncomment +Podfile +Pubspec +realtime +signups +slidable +nullable +compilable +composables +uncheck +todo +todos +todolists +hardcode +hardcoding +teardown +lookups +unsynced +repo +repos +monorepo +retryable +pdf +deduplicate +geo + +# Acronyms +UUID +UUIDs +SDK +SDKs +SLA +SLAs +DAU +DAUs +API +APIs +URI +URIs +VPC +VPCs +CRDT +CRDTs +ORM +ORMs +IPs +JWT +JWTs + +# Code terms +jsonb +varchar +uuid +timestamptz +datetime +unixepoch +subsec +macaddr +inet +bytea +DBPointer + +# Products/Companies +Power[Ss]ync +Supabase +Postgres +PostgreSQL +Coolify +Netlify +Vue +Kotlin +Multiplatform +Kysely +Stytch +Xcode +Cocoapods +MySQL +Ngrok +Tamagui +Prisma +Tauri +shadcn +Jepsen +WorkManager +SQLCipher +RSocket +KMMBridge +Yjs +Gradle +npx +cron +nginx \ No newline at end of file diff --git a/.github/vale/config/vocabularies/Terms/accept.txt b/.github/vale/config/vocabularies/Terms/accept.txt deleted file mode 100644 index a6d511de..00000000 --- a/.github/vale/config/vocabularies/Terms/accept.txt +++ /dev/null @@ -1,41 +0,0 @@ -(?i)sdk -(?i)sdks -(?i)api -(?i)apis -(?i)vpc -(?i)vpcs -(?i)crdt -(?i)crdts -(?i)orm -(?i)orms -(?i)ips -(?i)jwt -(?i)jwts -(?i)dev -(?i)subnet -(?i)subnets -(?i)hostname -(?i)config -(?i)serverless -(?i)failover -(?i)schemaless -(?i)sharded -(?i)powersync -(?i)supabase -(?i)postgres -(?i)coolify -(?i)netlify -(?i)vue -(?i)kotlin -(?i)multiplatform -(?i)kysely -(?i)stytch -(?i)xcode -(?i)cocoapods -(?i)mysql -(?i)ngrok -(?i)binlog -(?i)tauri -(?i)shadcn -(?i)jepsen -(?i)repo \ No newline at end of file diff --git a/.vale.ini b/.vale.ini index 54adb6fd..3a6d9a38 100644 --- a/.vale.ini +++ b/.vale.ini @@ -1,21 +1,27 @@ -StylesPath = .github/vale +# Top level styles +StylesPath=.github/vale MinAlertLevel = suggestion -Vocab = Terms -IgnoredScopes = code, tt -SkippedScopes = script, style, pre +IgnoredScopes = code, tt, img, url, a +SkippedScopes = script, style, pre, figure, code +# Vocabularies +Vocab = Mintlify, PowerSync + +# This is required since Vale doesn't officially support MDX [formats] mdx = md +# MDX support [*.mdx] -BasesOnStyles = Vale -Vale.Spelling = YES -CommentDelimiters = {/*, */} +BasedOnStyles = Vale +Vale.Terms = NO # Enforces really harsh capitalization rules, keep off TokenIgnores = (?sm)((?:import|export) .+?$), \ (?)(?!`), \ (<[A-Z]\w+>.+?<\/[A-Z]\w+>) +# Exclude: BlockIgnores = (?sm)^(<\w+\n .*\s\/>)$, \ -(?sm)^({.+.*}), \ -(?sm)^(\x60\x60\x60[\w ]*\n.*\x60\x60\x60)$ +(?sm)^({.+.*}) + +CommentDelimiters = {/*, */} \ No newline at end of file From 49fe538f32bc12b2c0c98b3c17459308bd3f3a54 Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Tue, 11 Mar 2025 07:15:35 +0200 Subject: [PATCH 09/10] add some missing terms --- .github/vale/config/vocabularies/PowerSync/accept.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/vale/config/vocabularies/PowerSync/accept.txt b/.github/vale/config/vocabularies/PowerSync/accept.txt index 8f1ff992..ae5eed77 100644 --- a/.github/vale/config/vocabularies/PowerSync/accept.txt +++ b/.github/vale/config/vocabularies/PowerSync/accept.txt @@ -8,6 +8,8 @@ serverless failover schemaless sharded +sharding +pooler binlog walkthrough denormalize @@ -44,6 +46,9 @@ retryable pdf deduplicate geo +subqueries +deprovisioned +liveness # Acronyms UUID @@ -80,6 +85,12 @@ macaddr inet bytea DBPointer +replicaset +clusterTime +cacert +jwks_uri +listitem +client_auth # Products/Companies Power[Ss]ync From 6d8498844c160d894a9de67dc584c3ee33dee673 Mon Sep 17 00:00:00 2001 From: Luc de Cafmeyer Date: Tue, 11 Mar 2025 07:21:57 +0200 Subject: [PATCH 10/10] add some missing terms --- .github/vale/config/vocabularies/PowerSync/accept.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/vale/config/vocabularies/PowerSync/accept.txt b/.github/vale/config/vocabularies/PowerSync/accept.txt index ae5eed77..5f53f1ce 100644 --- a/.github/vale/config/vocabularies/PowerSync/accept.txt +++ b/.github/vale/config/vocabularies/PowerSync/accept.txt @@ -13,9 +13,11 @@ pooler binlog walkthrough denormalize +denormalization defragment defragmenting defragmentation +hotfix wifi polyfill polyfills