(fix): pass dbName instead of key to setSyncEnabled in getSyncEnabled…#925
Merged
Conversation
|
simolus3
approved these changes
Apr 13, 2026
Contributor
|
Thank you! |
Contributor
Author
|
Thank God and you're welcome. I'm glad i could. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
getSyncEnabled, when no value exists in localStorage for the given key, the fallback call tosetSyncEnabledincorrectly passeskey(the already-prefixed string e.g.syncEnabled-example.db) instead ofdbName. This causessetSyncEnabledto construct a double-prefixed key (syncEnabled-syncEnabled-example.db), creating a separate localStorage entry that is never read bygetSyncEnabled.Fix
Pass
dbNameinstead ofkeytosetSyncEnabledin the fallback branch.Evidence
Two keys are created in localStorage instead of one when
getSyncEnabledis called for the first time:syncEnabled-example.db(correct)syncEnabled-syncEnabled-example.db(erroneous duplicate)