New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building against system libraries #178
Comments
Yes, this would be a good improvement. |
I'm almost done packaging all five. It appears to be sufficient to remove the "external" directory altogether and remove any references to it in the main CMake list. |
Yeah, removing references to the |
I agree that it would be good to have a separate target for running the tests (something like "make check" but for CMake, which I'm not familiar with). When packaging the external libraries I noticed that pugixml has no default installation target. Is it used as a static/shared library or are the sources embedded directly? If the latter: could it rather be linked against instead of "baking" the sources into the final object? |
We build it as a static library and link against it (https://github.com/powertab/powertabeditor/blob/master/source/CMakeLists.txt#L39 and https://github.com/powertab/powertabeditor/blob/master/external/CMakeLists.txt#L9) |
Okay, pugixml builds fine now. I'm having trouble with withershins --- it builds fine on its own, but when linked with powertabeditor I get linker errors:
I suppose this means that powertabeditor must also be linked against libbdf? |
Yeah - that happens implicitly in the current build. If one of the arguments to |
Thank you, I actually got it to build on the Guix System Distribution. |
Right now powertabeditor can only be built after fetching the code in
./external
. It would be good if the build system was flexible enough to allow building against these libraries even if they are not located in./external
but have been installed elsewhere in the system.(I'm currently packaging powertabeditor for GNU Guix and we like to avoid bundling libraries whenever possible.)
The text was updated successfully, but these errors were encountered: