Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #862 breaks backward compatibility for brokers #866

Closed
jecollins opened this issue Apr 30, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@jecollins
Copy link
Member

commented Apr 30, 2016

To address Issue #862 we added a new field isRegulation to TariffTransaction. Unfortunately, this class extends XStreamStateLoggable, which looks for a method or field in the class from which to extract and log the value of each field that appears in the xml message. Brokers build with earlier versions of common do not have this field and therefore the throw NSM exceptions when receiving TariffTransactions.

Clearly this cannot be fixed by a change in common, because backward compatibility requires the use of old versions of common. Perhaps we need a different solution to #862, although it's not exactly clear what that would be.

@jecollins

This comment has been minimized.

Copy link
Member Author

commented May 2, 2016

I ran a 1.2.0 broker in a sim session on a 1.3.2-SNAPSHOT server, and there were no errors. So it's not clear at all the backward-compatibility is broken. Perhaps the issue has to do with a new version of XStream?

@jecollins

This comment has been minimized.

Copy link
Member Author

commented May 3, 2016

This does not appear to be a backward-compatibility issue. If/when we find out what actually happened, we can create an appropriate issue to handle it. In the meantime, I'm closing this one.

@jecollins jecollins closed this May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.