Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-numeric prices in wholesale market orders may cause problems #937

Closed
jecollins opened this issue May 19, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jecollins
Copy link
Member

commented May 19, 2017

As reported by Serkan: When I put an order in the wholesale market for an amount with a non-numeric price (can be any string or NaN, Inf), then my cash position is delivered as "NaN" and no longer come back to normal. A small problem, but may happen.

@jecollins jecollins added this to the 2017 pre-competition milestone May 19, 2017

@jecollins jecollins self-assigned this May 19, 2017

@jecollins

This comment has been minimized.

Copy link
Member Author

commented May 19, 2017

The limitPrice field of Order is a Double, so arbitrary strings are not possible. Updated getLimitPrice() to return null if value is NaN, log error if constructor called with limitPrice = NaN. Deployed in 1.4.3-SNAPSHOT.

@jecollins jecollins closed this May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.