Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fixed game length without informing brokers #963

Closed
jecollins opened this issue Mar 14, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@jecollins
Copy link
Member

commented Mar 14, 2018

Currently, game length is determined by a random draw using two numbers that are known to brokers through the Competition object. The only way to fix the game length, thereby avoiding the random draw, is to make the min-length and expected-length equal, which signals the exact game length to brokers. Brokers are not supposed to know when the last timeslot will occur, because it's easy to exploit.

However, for both tournaments and for experiments it's important to be able to fix game length externally, using a config variable or a command-line option. The current scheme for determining game length needs to be able to accept such a value, while at the same time communicating to brokers min and expected length values that are not inconsistent with the fixed value.

@jecollins

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2018

Two questions:

  1. Which is better? CLI arg, or config var?
  2. How important is it to "manufacture" min and expected values that are "not inconsistent" with the hidden game-length value? Or should we just use a config approach and expect all three values to be provided if the hidden game-length is inconsistent with the default min and expected values?

I currently lean toward the config approach, and to just taking the three values without checking for consistency.

@govertbuijs

This comment has been minimized.

Copy link
Member

commented Mar 22, 2018

I think the config approach is preferable (the cli is full enough as it is).
This is fixed easily in TS and ES.

But do we communicate the min- and expected length to the brokers?
I thought that info was removed from the Competition info send to the brokers.
It shouldn't matter in a tournament setup any way, as these values should be fixed per tournament specs.

@jecollins

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2018

Competition now has fixedTimeslotCount config attribute, which is used by CompetitionControlService if present.

@jecollins jecollins closed this Mar 22, 2018

@jecollins

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2018

You were correct, Govert. There was almost no point in this change, but maybe it makes it a bit easier to explain how to fix the game length. Those fields of the Competition object were not being serialized, so brokers already had no information about game length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.