Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixes #135: Updated Hidden type to specify tagName #136

Closed
wants to merge 1 commit into from

3 participants

@paulyoung
  • Ensures that the Hidden type uses an input tag instead of a div.
  • Adding tagName seemed more appropriate than extending Text instead of Base.
@paulyoung paulyoung Fixes #135: Updated Hidden type to specify tagName
  * Ensures that the Hidden type uses an input tag instead of a div.
  * Adding tagName seemed more appropriate than extending Text instead of Base.
6b5fbdb
@powmedia
Owner

The hidden fields don't get rendered at all at the moment; which I want to update for the situation that you're submitting the form via regular form POST, so I'll include this when that work is done.

@philfreo
Collaborator

Looks like at the moment specifying in the schema { fieldname: 'Hidden' } actually does render it in the DOM (as a div), but that { fieldname: { type: 'Hidden' } } keeps it out altogether.

http://jsfiddle.net/c5QHr/50/

This was referenced
@powmedia
Owner

Hidden fields are now rendered properly in the latest version on master

@powmedia powmedia closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 29, 2012
  1. @paulyoung

    Fixes #135: Updated Hidden type to specify tagName

    paulyoung authored
      * Ensures that the Hidden type uses an input tag instead of a div.
      * Adding tagName seemed more appropriate than extending Text instead of Base.
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  src/editors.js
View
2  src/editors.js
@@ -395,6 +395,8 @@ Form.editors = (function() {
//HIDDEN
editors.Hidden = editors.Base.extend({
+ tagName: 'input'
+
defaultValue: '',
initialize: function(options) {
Something went wrong with that request. Please try again.