Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Groovy dependency from commons module #1023

Closed
geofjamg opened this issue Nov 19, 2019 · 0 comments · Fixed by #1027
Closed

Remove Groovy dependency from commons module #1023

geofjamg opened this issue Nov 19, 2019 · 0 comments · Fixed by #1027
Assignees

Comments

@geofjamg
Copy link
Member

  • Do you want to request a feature or report a bug?
    Feature

  • What is the current behavior?
    powsybl-commons module depends on Groovy runtime because of a very small utility class AbstractAstTransformation. Groovy runtime is a little bit heavy (7mo) and as all the other modules depends on commons, every piece of code based on powsybl embed Groovy runtime. In my opinion this is a bad design.

  • What is the expected behavior?
    AbstractAstTransformation should be removed from powsybl-commons. 3 solutions:

    • Copy the code in CalculatedTimeSeriesDslAstTransformation and PowsyblDslAstTransformation.
    • Move AbstractAstTransformation to powsybl-dsl and add the dependency in powsybl-time-series-api.
    • Create a new module just for that...
  • What is the motivation / use case for changing the behavior?

  • Please tell us about your environment:

    • PowSyBl Version: ...
    • OS Version: ...
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

(if a question doesn't apply, you can delete it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants