Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete node count #1161

Merged
merged 11 commits into from
Mar 11, 2020
Merged

Delete node count #1161

merged 11 commits into from
Mar 11, 2020

Commits on Mar 9, 2020

  1. Delete nodeCount attribute and related methods in IIDM node/breaker v… 

    …oltage levels

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

 correct code smells

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

Update javadoc on VoltageLevel.cleanTopology()

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

Add removeInternalConnection + Change mechanism (delete cleanTopology and auto-clean each time a connectable, a switch or an internal connection is removed)

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    ac54661 View commit details
    Browse the repository at this point in the history

  2. Delete unused method 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    a74c2ef View commit details
    Browse the repository at this point in the history

  3. Change removeInternalConnection into removeInternalConnections 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    34a569e View commit details
    Browse the repository at this point in the history

  4. Add test for removing internal connections 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    1b25d22 View commit details
    Browse the repository at this point in the history

  5. delete last use of getNodeCount() 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    857120c View commit details
    Browse the repository at this point in the history

  6. Use fail() method rather than a boolean 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    1e68909 View commit details
    Browse the repository at this point in the history

  7. Take reviews into account: add javadoc + simplify code + small renaming 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    aed1456 View commit details
    Browse the repository at this point in the history

  8. removeInternalConnections is not oriented 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    35c2892 View commit details
    Browse the repository at this point in the history

  9. Apply reviews: make availableVertices a TIntHashSet 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    72b9414 View commit details
    Browse the repository at this point in the history

  10. Corrections after rebasing master 

    Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
    @miovd
    miovd committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    861d752 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Merge branch 'master' into delete_node_count

    @miovd
    miovd committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    a5a4ca9 View commit details
    Browse the repository at this point in the history